Repository navigation
Release: update Makefile before build, then PR to sync master - #18
Closed
silverbucket wants to merge 1 commit into
Closed
silverbucket wants to merge 1 commit into
silverbucket wants to merge 1 commit into
Conversation
- Compute version, sed Makefile locally, test, build, publish - Build fails if Makefile and release version differ - Follow-up PR updates master under branch protection Co-authored-by: Nick Jennings <silverbucket@users.noreply.github.com>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong with PR #17
PR #17 only changed documentation and labels. It did not change build order on
master.What this PR changes
Order inside the release job:
1.3.3from latest tag + patch)masteryet)dwatch/cmd.Versionvia-ldflags)masterMakefile catches up (branch protection)Proof published assets already report correct versions
v1.3.1→dwatch version 1.3.1v1.3.2→dwatch version 1.3.2masteralready passes the computed version via-ldflagsat build time. This PR makes the order explicit and adds a guard so we never build if the Makefile in the job is wrong.Supersedes #17.