Skip to content

Release: update Makefile before build, then PR to sync master - #18

Closed
silverbucket wants to merge 1 commit into
masterfrom
cursor/release-makefile-before-build-91b9
Closed

silverbucket wants to merge 1 commit into
masterfrom
cursor/release-makefile-before-build-91b9

Conversation

@silverbucket

Copy link
Copy Markdown
Owner

What was wrong with PR #17

PR #17 only changed documentation and labels. It did not change build order on master.

What this PR changes

Order inside the release job:

  1. Compute next version (e.g. 1.3.3 from latest tag + patch)
  2. Update Makefile in the CI checkout (not on master yet)
  3. Run tests
  4. Build tarballs (refuses to build if Makefile ≠ release version; sets dwatch/cmd.Version via -ldflags)
  5. Publish GitHub Release
  6. Open PR so master Makefile catches up (branch protection)

Proof published assets already report correct versions

  • v1.3.1 → dwatch version 1.3.1
  • v1.3.2 → dwatch version 1.3.2

master already passes the computed version via -ldflags at build time. This PR makes the order explicit and adds a guard so we never build if the Makefile in the job is wrong.

Supersedes #17.

Open in Web Open in Cursor 

- Compute version, sed Makefile locally, test, build, publish
- Build fails if Makefile and release version differ
- Follow-up PR updates master under branch protection

Co-authored-by: Nick Jennings <silverbucket@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented May 27, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 58cb1538-04fe-4f5f-8998-560b245151f6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/release-makefile-before-build-91b9

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants