Repository navigation
Move release docs to release.md; fix protected-master workflow - #15
Conversation
- Add release.md with environment setup, cut-a-release, and protected master notes - Remove Releasing section from README (install-from-release stays for users) - Point release workflow comment at release.md - Include protected-master release workflow (no direct push to master) Co-authored-by: Nick Jennings <silverbucket@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe release workflow is refactored to source the current version from the latest published GitHub release tag (with Makefile fallback), add PR write permissions, remove direct Makefile edits on master, and introduce a post-publish PR workflow to sync the Makefile VERSION. Release documentation moves from README to a dedicated release.md file. ChangesRelease Workflow Restructuring and Documentation
Sequence Diagram(s)Not applicable. The changes are workflow configuration updates and documentation migration without distinct multi-component interactions that would benefit from sequence visualization. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Stale comment
Security review complete: no medium, high, or critical vulnerabilities found in the added or modified workflow/docs.
Reviewed the release workflow changes for privilege expansion, secret exposure, command injection, and branch/protection bypass. The workflow-dispatch input remains a bounded choice, version/tag/branch values are derived from validated
X.Y.Znumeric components, actions are pinned, and the release environment gate is preserved. No prior automation review threads were present to re-report.Sent by Cursor Automation: Find vulnerabilities
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/release.yml:
- Around line 46-53: The current LATEST_TAG selection can pick
drafts/prereleases like v1.4.0-rc1 which breaks semver checks; update the gh
release list invocation used to set LATEST_TAG so it excludes drafts and
prereleases and only returns a semver tagName (e.g., add --exclude-drafts
--exclude-prereleases and/or a jq filter to match ^v[0-9]+\.[0-9]+\.[0-9]+$),
keeping the rest of the fallback to reading Makefile VERSION into CURRENT
unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 39858bac-06f8-45cd-8400-1e5512950c0f
📒 Files selected for processing (3)
.github/workflows/release.ymlREADME.mdrelease.md
💤 Files with no reviewable changes (1)
- README.md
- gh release list: --exclude-drafts --exclude-pre-releases - jq filter for semver vX.Y.Z tags only Co-authored-by: Nick Jennings <silverbucket@users.noreply.github.com>
There was a problem hiding this comment.
Security review complete: no medium, high, or critical vulnerabilities found in the added or modified workflow/docs.
Validated the current release workflow changes for command injection, privilege expansion, secret leakage, and protected-branch bypass. The new privileged operations only consume workflow choice input or semver-filtered version/tag values, actions remain pinned, the release environment gate remains in place, and the previous workflow reliability thread is already addressed/resolved. No new finding comments are being left.
Sent by Cursor Automation: Find vulnerabilities


Summary
release.md— maintainer docs: environment setup, cut-a-release, version bumps, protectedmaster/ Makefile PR flowREADME.md— removed the Releasing section; Install from a release stays for end users.github/workflows/release.yml— protected-master behavior from Release workflow: respect protected master (no direct push) #14 (no direct push; infer version from latest release; Makefile sync PR) + comment points torelease.mdSupersedes/closes the workflow half of #14; merge this instead of #14 if you want both fixes in one PR.
Summary by CodeRabbit
Documentation
Chores