Fix temp file collisions during concurrent evals - #20
Open
tuanvumaihuynh wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a helper to generate more unique temp file names and updates Figma evaluation code paths to use it.
Changes:
- Introduces
tmpName(prefix, ext)for temp file path generation using PID/time/random bytes - Switches temp payload/script/result filenames in
figmaEvalSynctotmpName(...)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+33
to
+35
| function tmpName(prefix, ext) { | ||
| return join(tmpdir(), `${prefix}-${process.pid}-${Date.now()}-${randomBytes(6).toString('hex')}.${ext}`); | ||
| } |
Comment on lines
+33
to
+35
| function tmpName(prefix, ext) { | ||
| return join(tmpdir(), `${prefix}-${process.pid}-${Date.now()}-${randomBytes(6).toString('hex')}.${ext}`); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Concurrent commands can create temp files in the same millisecond when filenames only use
Date.now(). That can cause one process to read, overwrite, or remove another process's payload/result file.Validation
node --check src/index.jsnpm testverifycommands against different Figma frames and confirmed each returned the expected frame id/name.evalcommands with distinct payloads and confirmed responses stayed isolated.