Skip to content

Remove deprecated codecov/test-results-action#3905

Open
pmachapman wants to merge 2 commits into
masterfrom
update/gha
Open

Remove deprecated codecov/test-results-action#3905
pmachapman wants to merge 2 commits into
masterfrom
update/gha

Conversation

@pmachapman
Copy link
Copy Markdown
Collaborator

@pmachapman pmachapman commented May 25, 2026

This PR fixes the following warnings thrown by the Build and test (ubuntu-24.04, 10.0.x, 22.13.0, 11.11.0) GHA:

This action is being deprecated in favor of 'codecov-action'.
      Please update CI accordingly to use 'codecov-action@v5' with
      'report_type: test_results'.
      The 'codecov-action' should and can be run at least once for
      coverage and once for test results
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea, codecov/test-results-action@0fa95f0e1eeaafde2c782583b36b28ad0d8c77d3. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/

I have also fixed the two grit_check warnings I noticed when reviewing the GHA grit-check:

./src/SIL.XForge.Scripture/ClientApp/src/app/shared/progress-service/progress.service.spec.ts#L133
then_resolve
grit-check: ./src/SIL.XForge.Scripture/ClientApp/src/app/shared/progress-service/progress.service.spec.ts#L132
then_resolve

This change is Reviewable

@codecov
Copy link
Copy Markdown

codecov Bot commented May 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.90%. Comparing base (a9476dc) to head (a202506).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3905      +/-   ##
==========================================
- Coverage   80.90%   80.90%   -0.01%     
==========================================
  Files         630      630              
  Lines       40677    40677              
  Branches     6602     6578      -24     
==========================================
- Hits        32909    32908       -1     
- Misses       6728     6742      +14     
+ Partials     1040     1027      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmachapman pmachapman deployed to screenshot_diff May 25, 2026 02:10 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant