SF-3801 Show chapters with content that adding a draft will overwrite#3903
SF-3801 Show chapters with content that adding a draft will overwrite#3903RaymondLuong3 wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3903 +/- ##
=======================================
Coverage 80.90% 80.90%
=======================================
Files 630 630
Lines 40677 40679 +2
Branches 6578 6578
=======================================
+ Hits 32909 32911 +2
Misses 6741 6741
Partials 1027 1027 ☔ View full report in Codecov by Sentry. |
|
@copilot Here is the original Jira issue for this change: === Start Jira issue === Enumerate the chapters that have content Please do a code review and a functionality review. |
| "importing": "Importing", | ||
| "next": "Next", | ||
| "no_books_ready_for_import": "No draft chapters are ready for import. Generate a draft and try again.", | ||
| "overwrite_book_description": "{{ bookName }} in {{ boldStart }}{{ projectShortName }} - {{ projectName }}{{ boldEnd }} has {{ numChapters }} chapters with existing text that will be overwritten.", |
There was a problem hiding this comment.
It seems to me that we've lost a significant amount of clarity by going from specifically stating that there are chapters with existing text that will be overwritten to just saying "Overwrite ?" I know technically we're overwriting the entire book, but from a user's perspective they're doing an import, probably not expecting to overwrite anything. We should be extremely clear in why we are stopping to ask an additional question.
0faa88e to
7047530
Compare
|
Sorry about the Copilot commits. I've reverted them (I was trying to get it to review, not make changes). I think you may want to re-read the issue description. |
This PR specifically lists the chapters that will get overwritten when applying a draft to a book. The chapters listed can be clicked and a new tab opens in the browser to allow the user view the content of the chapter.
Adding a single book to a project
Adding multiple books to a project

This change is