Skip to content

SF-3805 Allow installation of two resources with the same name#3893

Merged
RaymondLuong3 merged 1 commit into
masterfrom
fix/SF-3805
May 20, 2026
Merged

SF-3805 Allow installation of two resources with the same name#3893
RaymondLuong3 merged 1 commit into
masterfrom
fix/SF-3805

Conversation

@pmachapman
Copy link
Copy Markdown
Collaborator

@pmachapman pmachapman commented May 18, 2026

This PR fixes an issue where installing two resources with the same name will not work if the Scripture Forge process is restarted between the two installations.


This change is Reviewable

@pmachapman pmachapman added the will require testing PR should not be merged until testers confirm testing is complete label May 18, 2026
@pmachapman pmachapman temporarily deployed to screenshot_diff May 18, 2026 22:31 — with GitHub Actions Inactive
@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.89%. Comparing base (6f829e4) to head (1221ea8).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...rge.Scripture/Services/SFInstallableDblResource.cs 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3893      +/-   ##
==========================================
- Coverage   80.90%   80.89%   -0.02%     
==========================================
  Files         630      630              
  Lines       40654    40657       +3     
  Branches     6600     6596       -4     
==========================================
- Hits        32891    32889       -2     
+ Misses       6738     6728      -10     
- Partials     1025     1040      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Collaborator

@RaymondLuong3 RaymondLuong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@RaymondLuong3 reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

@RaymondLuong3 RaymondLuong3 self-assigned this May 19, 2026
@RaymondLuong3 RaymondLuong3 added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels May 19, 2026
@RaymondLuong3 RaymondLuong3 added testing complete Testing of PR is complete and should no longer hold up merging of the PR and removed ready to test labels May 20, 2026
@RaymondLuong3 RaymondLuong3 merged commit 5d921ea into master May 20, 2026
33 checks passed
@RaymondLuong3 RaymondLuong3 deleted the fix/SF-3805 branch May 20, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing complete Testing of PR is complete and should no longer hold up merging of the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants