Reuse integration test project data in RootSite tests

[johnml1135]

Summary

• reuse a fixed integration_test_data project name in RealDataTestsBase instead of generating a new RealDataTest_<guid> project for each run
• delete the actual created project directory before setup and after teardown so repeated test runs do not accumulate dummy projects
• keep the change scoped to the RootSite real-data test base used by the render verification/timing fixtures

Validation

• ./test.ps1 -TestProject RootSiteTests -TestFilter "FullyQualifiedName~RenderVerifyTests" -NoBuild
• CI: Whitespace check
• CI: Commit messages

---

This change is 

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Reworks RootSite real-data test setup/teardown to reuse a fixed integration test project name and clean up the created project directory between runs, avoiding accumulation of dummy projects.

Changes:

• Use a constant project name (integration_test_data) instead of a per-run GUID project name.
• Delete the project directory before setup and after teardown.
• Track the created project directory from CreateNewLangProj and reuse it for cleanup.

[github-actions]

NUnit Tests

    1 files  ±0      1 suites  ±0   11m 34s ⏱️ + 1m 1s
4 204 tests  - 1  4 133 ✅  - 1  71 💤 ±0  0 ❌ ±0 
4 213 runs   - 1  4 142 ✅  - 1  71 💤 ±0  0 ❌ ±0 

Results for commit 9dab396. ± Comparison against base commit 5ce891b.

This pull request removes 2 and adds 1 tests. Note that renamed tests count towards both.

SIL.FieldWorks.Language.ManagedVwWindowTests ‑ NotSettingWindowTest
SIL.FieldWorks.Language.ManagedVwWindowTests ‑ SimpleWindowTest

SIL.FieldWorks.Common.RootSites.RootSiteTests.RealDataTestsBaseCleanupTests ‑ RunSetupFailureCleanup_ReleasesMutexEvenWhenDisposeFails

♻️ This comment has been updated with latest results.

[jasonleenaylor]

Src/Common/RootSite/RootSiteTests/RealDataTestsBase.cs line 246 at r2 (raw file):

			}

			Exception lastException = null;

Look at SIL.IO.RobustIO.DeleteDirectoryAndContents to replace most of this methd.

[jasonleenaylor]

Src/Common/RootSite/RootSiteTests/RealDataTestsBase.cs line 107 at r2 (raw file):

				DisposeCache();
				TryDeleteProjectDirectoryAfterSetupFailure();
				ReleaseProjectMutex();

There is an unlikely but potentially problematic situation where either DisposeCache or the TryDeleteProjectDirectoryAfterSetupFailure throw, which would not release the Mutex. Might want to guard against that.

[johnml1135]

Addressed Jason's two review points in the local follow-up.

• Setup failure cleanup now routes through RunSetupFailureCleanup so mutex release is guaranteed even if earlier cleanup steps fail unexpectedly. The setup-failure path also uses TryDisposeCacheAfterSetupFailure so a cache-disposal problem does not strand the mutex or mask the original setup exception.
• Directory cleanup keeps the existing sentinel and exact-path safety checks, but now reuses SIL.IO.RobustIO.DeleteDirectoryAndContents instead of the custom recursive delete loop.

Local validation:

• ./test.ps1 -TestProject RootSiteTests -TestFilter "FullyQualifiedName~RealDataTestsBaseCleanupTests"
• ./test.ps1 -NoBuild -TestProject RootSiteTests -TestFilter "FullyQualifiedName~RenderVerifyTests"

Relevant local anchors:

• Src/Common/RootSite/RootSiteTests/RealDataTestsBase.cs lines 104, 183, 219, 308
• Src/Common/RootSite/RootSiteTests/RealDataTestsBaseCleanupTests.cs line 11

[johnml1135]

Src/Common/RootSite/RootSiteTests/RealDataTestsBase.cs line 107 at r2 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

There is an unlikely but potentially problematic situation where either DisposeCache or the TryDeleteProjectDirectoryAfterSetupFailure throw, which would not release the Mutex. Might want to guard against that.

fixed

[johnml1135]

Src/Common/RootSite/RootSiteTests/RealDataTestsBase.cs line 246 at r2 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

Look at SIL.IO.RobustIO.DeleteDirectoryAndContents to replace most of this methd.

Changed out - I also added a skill to guide the AI to use SIL's models.

[jasonleenaylor]

@jasonleenaylor reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on johnml1135).