Repository navigation
Conversation
The reprocess queue dispatches a single reconstruction attempt per block root. A gossip column requested reconstruction regardless of how many columns were cached, so an attempt could be dispatched with fewer than half of the columns. That attempt was declined and no later column scheduled another one. Past the reconstruction deadline the delay is zero, so this happened on the first column of a late block. `check_reconstruction_trigger` now returns early while fewer than half of the columns are cached, so the single attempt is only spent when reconstruction is possible. `PendingComponents::num_completed_columns` and `get_cached_data_columns_indices` no longer build the sidecars to count complete columns, as the trigger now queries them for every gossip column.
|
Tick the box to add this pull request to the merge queue (same as
|
dapplion
reviewed
Nov 11, 2026
| .chain | ||
| .cached_data_column_indexes(block_root, epoch) | ||
| .map_or(0, |indexes| indexes.len()); | ||
| if cached_column_count < T::EthSpec::number_of_columns() / 2 { |
Collaborator
There was a problem hiding this comment.
This repeats the threshold from check_and_set_reconstruction_started, so the two can drift. Could the reprocess queue free the root when an attempt is declined or fails instead, or could both places use one shared predicate?
Member
Author
There was a problem hiding this comment.
added a helper and migrated usages to it
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
The reprocess queue dispatches a single reconstruction attempt per block root. A gossip column requested reconstruction regardless of how many columns were cached, so an attempt could be dispatched with fewer than half of the columns. That attempt was declined and no later column scheduled another one. Past the reconstruction deadline the delay is zero, so this happened on the first column of a late block.
Proposed Changes
check_reconstruction_triggernow returns early while fewer than half of the columns are cached, so the single attempt is only spent when reconstruction is possible.PendingComponents::num_completed_columnsandget_cached_data_columns_indicesno longer build the sidecars to count complete columns, as the trigger now queries them for every gossip column.