Repository navigation
merge queue: checking #10418 on unstable (ec2442d) - #10427
Closed
mergify[bot] wants to merge 3 commits into
Closed
mergify[bot] wants to merge 3 commits into
mergify[bot] wants to merge 3 commits into
Conversation
After Gloas, the beacon node asks each direct builder for a bid with
getExecutionPayloadBid at block production. With the experimental
--builder-bid-streaming flag (off by default) it can instead open a
websocket bid stream to each builder just before its slot:
GET /eth/v1/builder/execution_payload_bid_stream/{slot}/{parent_hash}/
{parent_root}/{proposer_pubkey}, one [0x01][fork byte][SSZ
SignedExecutionPayloadBid] message per bid.
The beacon node keeps the builder_preferences entries the validator
client posts, and once it knows the parent for its next slot it prepares
a stream per entry. Each stream connects a second before the slot, with
Date-Milliseconds and X-Timeout-Ms giving slot start as the deadline, the
same way an HTTP bid request gives its deadline, so builders send their
bid just before it. The latest bid is kept until block production.
At block production each builder's bid comes from its stream or from
HTTP, and goes through the same validation as an HTTP bid:
- A stream with a bid gives that bid. If it fails to decode or validate,
request over HTTP.
- A stream that connected but got no bid means no bid.
- With no stream, a stream that never connected, or one opened for a
different parent or auth, request over HTTP as before.
The proposal's streams are then closed, and they are also closed when
block production skips direct bids. A bid's signature is only decoded at
block production, on the blocking pool. Each stream has limits on message
size, message count and bytes read, a proposal streams from at most 64
builders, and a stream doesn't connect with less than 500ms left. Streams
trust the same roots as the HTTP client.
- Do all bid stream timing on the slot clock instead of Instant::now. - Read the proposer pubkey for bid streams from the head state, so proposer prep doesn't lock the pubkey cache. - Call the time block production takes the bids the auction end. - Try a builder that answered 404 or 405 again at its next proposal, instead of using HTTP for it until restart.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This is a merge queue draft opened by Mergify. Nobody needs to act on it.
Mergify opened it for batch liquid-viennoise-t8n55p of the
defaultqueue, to test #10418 before it merges intounstable. Pushing to this branch or closing this pull request removes #10418 from the queue.What this draft tests
Mergify checks that #10418 still passes CI on top of
unstable. CI runs on this draft's code, built in this order:unstableatec2442d🎉 Where it stands: checks passed
CI passed on this draft.
Follow the
defaultqueue in the dashboardWhat happens next
unstableand closes this draft.Metadata for CI tooling, read by
mergify ciRequired conditions of queue rule
defaultfor mergecheck-success=local-testnet-successcheck-success=test-suite-successgithub-review-approved[🛡 GitHub branch protection]Required conditions to stay in the queue
#approved-reviews-by >= 1check-success=license/clacheck-success=target-branch-checkgithub-review-approved[🛡 GitHub branch protection]label!=do-not-merge