Repository navigation
Conversation
|
Tick the box to add this pull request to the merge queue (same as
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Closes #10118
Proposed Changes
Adds 5 end-to-end tests for invalid finalized payloads:
gloas_invalid_finalized_payload_on_empty_keeps_running_on_full_child_rejection: the EL catches up and rejects a minority child on the block'sFULLnode, invalidating the block's payload before it is finalized on itsEMPTYnode.gloas_invalid_finalized_payload_on_empty_keeps_running_on_optimistic_sync: a syncing EL imports the block's invalid payload optimistically, and the block is finalized on itsEMPTYnode before the EL catches up.gloas_invalid_finalized_payload_on_empty_keeps_running_on_envelope_rejection: a synced EL rejects the block's payload on arrival, and the block is finalized on itsEMPTYnode.gloas_invalid_finalized_payload_on_full_shuts_down_on_optimistic_sync: a syncing EL imports the block's invalid payload optimistically, the block is finalized on itsFULLnode, and the EL rejects the chain after catching up, causing the node to shut down at the justified check.pre_gloas_invalid_finalized_payload_with_gloas_descendants_shuts_down: a pre-Gloas finalized block carries its own payload, so invalidating it marks its Gloas descendants invalid too and shuts the node down through the finalized check.