Skip to content

Add Gloas tests for invalid finalized payloads - #10175

Open
SamAg19 wants to merge 7 commits into
sigp:unstablefrom
SamAg19:invalid-finalized-payload-tests
Open

SamAg19 wants to merge 7 commits into
sigp:unstablefrom
SamAg19:invalid-finalized-payload-tests

Conversation

@SamAg19

@SamAg19 SamAg19 commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Issue Addressed

Closes #10118

Proposed Changes

Adds 5 end-to-end tests for invalid finalized payloads:

  • gloas_invalid_finalized_payload_on_empty_keeps_running_on_full_child_rejection: the EL catches up and rejects a minority child on the block's FULL node, invalidating the block's payload before it is finalized on its EMPTY node.
  • gloas_invalid_finalized_payload_on_empty_keeps_running_on_optimistic_sync: a syncing EL imports the block's invalid payload optimistically, and the block is finalized on its EMPTY node before the EL catches up.
  • gloas_invalid_finalized_payload_on_empty_keeps_running_on_envelope_rejection: a synced EL rejects the block's payload on arrival, and the block is finalized on its EMPTY node.
  • gloas_invalid_finalized_payload_on_full_shuts_down_on_optimistic_sync: a syncing EL imports the block's invalid payload optimistically, the block is finalized on its FULL node, and the EL rejects the chain after catching up, causing the node to shut down at the justified check.
  • pre_gloas_invalid_finalized_payload_with_gloas_descendants_shuts_down: a pre-Gloas finalized block carries its own payload, so invalidating it marks its Gloas descendants invalid too and shuts the node down through the finalized check.

@chong-he chong-he added test improvement Improve tests gloas ready-for-review The code is ready for review labels Oct 1, 2026
@cla-assistant

cla-assistant Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@mergify

mergify Bot commented Nov 10, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue). If it does not match the queue conditions yet, it enters the queue once it does.

  • Queue this pull request

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gloas ready-for-review The code is ready for review test improvement Improve tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants