docs(rest)+test(core): true live_transcribe call shape; drop stale ai_sidecar bypass - #85
Closed
grandcamel wants to merge 1 commit into
Closed
Conversation
…_sidecar bypass
calling.md showed live_transcribe(call_id, action="start", lang="en"),
but the generated signature takes action as a keyword-only TypedDict
union ({"start": {...}} or the literal "stop") and has no lang/from_lang
/to_lang parameters — copying the documented call raises TypeError. The
examples now show the real shape, with the start parameters inside the
action object where the schema defines them.
The sidecar pattern test appended ai_sidecar to the raw document with a
comment that the verb was not in the live SWML schema yet. It landed in
4645d48, so the test now uses add_verb_to_section directly — the path
the comment promised, and stronger, since the verb goes through schema
validation instead of around it.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MgA3KeCEPMKMJVvroZY1wV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small truth-corrections, no behavior changes.
rest/docs/calling.md— live transcribe/translate call shapeThe doc showed
but the generated signatures take
actionas a keyword-only union of TypedDicts (LiveTranscribeStartActionis{"start": {...}}), and neither method has alang/from_lang/to_langparameter — copying the documented call raisesTypeError: unexpected keyword argument. The start parameters live inside the action object (lang,webhook, … for transcribe;from_lang,to_lang, … for translate, matching the schema'sTranscribeStartAction/StartActiondefs). Updated the examples to the real shape, including theaction="stop"literal form.tests/unit/core/test_swml_service_swaig.py— stale ai_sidecar bypassThe sidecar-pattern test appended the
ai_sidecarverb to_current_documentby hand, with a comment saying the verb wasn't in the live SWML schema yet and that callers would useadd_verb_to_section"once the schema lands". The schema landed (4645d48):add_verb_to_section("main", "ai_sidecar", {...})now validates and returnsTrue. The test now exercises that supported path — which is also stronger, since the verb goes through schema validation instead of around it.🤖 Generated with Claude Code
https://claude.ai/code/session_01MgA3KeCEPMKMJVvroZY1wV