Skip to content

Fix flaky normalize_distribution test (float32 tolerance) #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AmitMY merged 1 commit into from
Jun 20, 2026
Merged

Fix flaky normalize_distribution test (float32 tolerance) #228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/python/tests/pose_tensorflow_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,9 @@ def test_pose_tf_posebody_normalize_distribution_eager_mode_correct_result(self)
actual_tensor_zero_filled = actual_tensor_nan_fixed.zero_filled()
actual_tensor_as_numpy = actual_tensor_zero_filled.numpy()

self.assertTrue(np.allclose(actual_tensor_as_numpy, expected_tensor),
# actual is float32 (TF), expected is float64 (numpy); atol must tolerate
# float32 rounding on near-zero values, where allclose's default 1e-8 is too tight.
self.assertTrue(np.allclose(actual_tensor_as_numpy, expected_tensor, atol=1e-4),
"Normalize distribution did not return the expected result.")

def test_pose_tf_posebody_frame_dropout_normal_eager_mode_num_frames_not_zero(self):
Expand Down
Loading