Skip to content

feat(info-page): adjust illustration size and spacing defaults - #2398

Merged
spike-rabbit merged 1 commit into
mainfrom
feat/adjust-size-in-info-page
Jul 30, 2026
Merged

feat(info-page): adjust illustration size and spacing defaults#2398
spike-rabbit merged 1 commit into
mainfrom
feat/adjust-size-in-info-page

Conversation

@mistrykaran91

@mistrykaran91 mistrykaran91 commented Jul 23, 2026

Copy link
Copy Markdown
Member
  • Set the default illustration slot size to 260x196px (overridable by projects).
  • Adjust gap between the image and title
  • Update playwright snapshots

Closes #2374


Documentation.
Examples.
Dashboards Demo.
Playwright report.

Coverage Reports:

Code Coverage

@mistrykaran91
mistrykaran91 force-pushed the feat/adjust-size-in-info-page branch 2 times, most recently from 94f26d3 to 620fc11 Compare July 23, 2026 09:04
@mistrykaran91 mistrykaran91 added this to the 51.0.0 milestone Jul 23, 2026
@mistrykaran91 mistrykaran91 added feature Marks feature requests and feature implementations ux Marks all UX related topics (UX team is working on or UX input is required) labels Jul 23, 2026
@mistrykaran91 mistrykaran91 self-assigned this Jul 23, 2026
@mistrykaran91
mistrykaran91 marked this pull request as ready for review July 23, 2026 09:26
@mistrykaran91
mistrykaran91 requested review from a team as code owners July 23, 2026 09:26

@panch1739 panch1739 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mistrykaran91 Awesome! Two things

The example of the illustration has the incorrect spacings

design:

Image

Implementation:

Image

In resposive behavior, the text and buttons remain left align. Could we mantain the center alignment? Would it be possible to follow this guidelines?

Image

@mistrykaran91
mistrykaran91 force-pushed the feat/adjust-size-in-info-page branch 3 times, most recently from 17a6fd8 to cfe01ef Compare July 24, 2026 05:23

@panch1739 panch1739 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@mistrykaran91
mistrykaran91 force-pushed the feat/adjust-size-in-info-page branch 3 times, most recently from 16a0f4c to 1e51f01 Compare July 24, 2026 09:34

@spike-rabbit spike-rabbit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the example use ngSrc and I guess you can remove the styling of the image then.

What about wrapping the info-actions in another div an style that?

Maybe this allows you to get rid of ng-deep.

I think for the icon-size, you don't need ng-deep at all.

Comment thread projects/element-ng/info-page/si-info-page.component.scss Outdated
@mistrykaran91
mistrykaran91 marked this pull request as draft July 28, 2026 05:14
@mistrykaran91

mistrykaran91 commented Jul 28, 2026

Copy link
Copy Markdown
Member Author

In the example use ngSrc and I guess you can remove the styling of the image then.

What about wrapping the info-actions in another div an style that?

Maybe this allows you to get rid of ng-deep.

I think for the icon-size, you don't need ng-deep at all.

I have ngSrcin the example now, but that style was there from previous purposely, just to demonstrate that the sizes can be overiden.

For icon-size- removing ng-deep, it might cause an issue in the stacked icon example because

@mistrykaran91
mistrykaran91 force-pushed the feat/adjust-size-in-info-page branch 2 times, most recently from a0102f6 to 0696c6b Compare July 28, 2026 06:48
@mistrykaran91
mistrykaran91 marked this pull request as ready for review July 28, 2026 07:03
@mistrykaran91
mistrykaran91 force-pushed the feat/adjust-size-in-info-page branch from d2caf72 to c5ed637 Compare July 28, 2026 10:15
- Adjust gap between the image and title
- Update playwright snapshots
@mistrykaran91
mistrykaran91 force-pushed the feat/adjust-size-in-info-page branch from c5d4a8e to 58bf4d6 Compare July 30, 2026 13:33

@spike-rabbit spike-rabbit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@spike-rabbit
spike-rabbit enabled auto-merge July 30, 2026 13:36
@spike-rabbit
spike-rabbit added this pull request to the merge queue Jul 30, 2026
Merged via the queue into main with commit 7834d2f Jul 30, 2026
15 checks passed
@spike-rabbit
spike-rabbit deleted the feat/adjust-size-in-info-page branch July 30, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Marks feature requests and feature implementations ux Marks all UX related topics (UX team is working on or UX input is required)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Info Page component

3 participants