Skip to content

Feat/markdown#2389

Draft
dr-itz wants to merge 4 commits into
mainfrom
feat/markdown
Draft

Feat/markdown#2389
dr-itz wants to merge 4 commits into
mainfrom
feat/markdown

Conversation

@dr-itz

@dr-itz dr-itz commented Jul 21, 2026

Copy link
Copy Markdown
Member

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a pluggable markdown rendering component (si-markdown) built on remark and unified, featuring extensions for KaTeX math, Mermaid diagrams, Highlight.js code highlighting, and sanitized inline HTML. It also integrates this component into the chat message UI. The code review feedback highlights a circular dependency between options and default extensions, unprofessional language in JSDoc comments, a lack of error handling in markdown parsing, and unsafe casting in the fragment component. Additionally, several violations of the style guide were identified regarding the use of the any type instead of unknown.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread projects/element-ng/markdown/si-markdown-options.ts
Comment thread projects/element-ng/markdown/utils/signal-utils.ts
Comment thread projects/element-ng/markdown/si-markdown.component.ts
Comment thread projects/element-ng/markdown/si-markdown-fragment.component.ts
Comment thread projects/element-ng/markdown/si-markdown-options.ts Outdated
Comment thread projects/element-ng/markdown/si-markdown-template.directive.ts
Comment thread projects/element-ng/markdown/si-markdown-token.ts
Comment thread projects/element-ng/markdown/si-markdown.component.ts
@dr-itz
dr-itz force-pushed the feat/markdown branch 6 times, most recently from 42473c1 to eeef2a2 Compare July 22, 2026 15:04
dr-itz added 4 commits July 23, 2026 13:18
@dr-itz

dr-itz commented Jul 23, 2026

Copy link
Copy Markdown
Member Author

@Killusions this is ready now. I'll wait with changes after feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant