refactor(loading-spinner): use inputBinding and remove injector logic to pass values - #2377
Conversation
chintankavathia
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the loading spinner component and directive to use Angular's portal input bindings instead of custom portal injectors, deprecating the LOADING_SPINNER_BLOCKING and LOADING_SPINNER_OVERLAY injection tokens. Feedback suggests explicitly typing the isSpinnerOverlay and isBlockingSpinner inputs as boolean to avoid type inference of unknown (violating strict type checking guidelines) and to prevent potential breaking changes for consumers.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
3b2f944 to
c3254ba
Compare
c3254ba to
e77d146
Compare
chintankavathia
added
the
breaking-changes
e77d146 to
c23ce6c
Compare
… to pass values BREAKING CHANGE: Removed `LOADING_SPINNER_BLOCKING` and `LOADING_SPINNER_OVERLAY` injection tokens. Use the corresponding inputs of `si-loading-spinner` instead.
c23ce6c to
384a042
Compare
spike-rabbit
left a comment
spike-rabbit
left a comment
There was a problem hiding this comment.
What about improving the input names?
FYI, with the force push I just changed the commit message.
384a042 to
55d9090
Compare
55d9090 to
384a042
Compare
4 participants
BREAKING CHANGE: removed
LOADING_SPINNER_BLOCKINGandLOADING_SPINNER_OVERLAYfromsi-loading-spinnerinjection tokens.Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports:
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: