Skip to content

fix(wizard): focus next step content#2372

Open
spike-rabbit wants to merge 1 commit into
mainfrom
fix/wizard-step-focus
Open

fix(wizard): focus next step content#2372
spike-rabbit wants to merge 1 commit into
mainfrom
fix/wizard-step-focus

Conversation

@spike-rabbit

@spike-rabbit spike-rabbit commented Jul 17, 2026

Copy link
Copy Markdown
Member

Focus the first tabbable control after advancing a step, falling back to the next button when the step has no tabbable control.\n\nCloses #2346


Documentation.
Examples.
Dashboards Demo.
Playwright report.

Coverage Reports:

Code Coverage

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements automatic focus management when navigating between wizard steps. When moving to the next step, the wizard now attempts to focus the first interactive (tabbable) element within that step, falling back to focusing the next button if no interactive elements are found. Unit tests have been added to verify this behavior. The reviewer suggested optimizing the DOM traversal in getFirstTabbableElement by using querySelectorAll('*') instead of recursive traversal.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread projects/element-ng/wizard/si-wizard.component.ts Outdated
Comment thread projects/element-ng/wizard/si-wizard.component.ts Outdated
@panch1739 panch1739 added this to the 51.0.0 milestone Jul 21, 2026
@spike-rabbit
spike-rabbit force-pushed the fix/wizard-step-focus branch 2 times, most recently from 0a40708 to ccf4902 Compare July 22, 2026 07:39
@spike-rabbit
spike-rabbit marked this pull request as ready for review July 22, 2026 13:39
@spike-rabbit
spike-rabbit requested review from a team as code owners July 22, 2026 13:39
Comment thread projects/element-ng/wizard/si-wizard.component.ts
Focus the first tabbable control after advancing a step, falling back to the next button when the step has no tabbable control.

Closes #2346
@spike-rabbit
spike-rabbit force-pushed the fix/wizard-step-focus branch from ccf4902 to 517af60 Compare July 23, 2026 05:58
@spike-rabbit
spike-rabbit requested a review from dr-itz July 23, 2026 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants