Skip to content

chore(examples): use httpResource api#2364

Open
chintankavathia wants to merge 1 commit into
mainfrom
chore/examples/use-http-resource
Open

chore(examples): use httpResource api#2364
chintankavathia wants to merge 1 commit into
mainfrom
chore/examples/use-http-resource

Conversation

@chintankavathia

@chintankavathia chintankavathia commented Jul 17, 2026

Copy link
Copy Markdown
Member

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the SampleComponent to use Angular's new resource APIs instead of manually subscribing to HttpClient inside ngOnInit. However, the reviewer pointed out that httpResource does not have a .text() method and will fail to fetch markdown files as JSON. They suggested using the resource API from @angular/core in combination with HttpClient configured for plain text response instead.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/app/examples/si-markdown-renderer/si-markdown-renderer.ts
@chintankavathia
chintankavathia marked this pull request as ready for review July 17, 2026 05:55
@chintankavathia
chintankavathia requested review from a team as code owners July 17, 2026 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant