Skip to content

feat(navbar-vertical): add tooltipOverride to items#2352

Draft
spike-rabbit wants to merge 1 commit into
mainfrom
feat/navbar-vertical-tooltip-override
Draft

feat(navbar-vertical): add tooltipOverride to items#2352
spike-rabbit wants to merge 1 commit into
mainfrom
feat/navbar-vertical-tooltip-override

Conversation

@spike-rabbit

@spike-rabbit spike-rabbit commented Jul 15, 2026

Copy link
Copy Markdown
Member

Allow consumers to override the automatic tooltip text (defaults to item label) on collapsed navbar items via a new tooltipOverride property on the item model. When provided, the tooltip is also enabled in the expanded state so it can be shown whenever needed.

Changes

  • Added tooltipOverride?: TranslatableString to NavbarVerticalItemBase
  • Updated [siTooltip] bindings to use item.tooltipOverride ?? item.label
  • Updated [isDisabled] so tooltip stays enabled in expanded state when tooltipOverride is provided

Documentation.
Examples.
Dashboards Demo.
Playwright report.

Coverage Reports:

Code Coverage

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a tooltipOverride property to vertical navbar items, allowing custom tooltip text to be displayed instead of the default item label. The review feedback highlights a potential issue where an empty string for tooltipOverride would still render an empty tooltip when collapsed, violating repository guidelines; it suggests explicitly disabling the tooltip in this scenario. Additionally, the feedback recommends updating the JSDoc documentation to accurately describe that the tooltip override is active in both expanded and collapsed states.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread projects/element-ng/navbar-vertical/si-navbar-vertical.model.ts
@spike-rabbit
spike-rabbit force-pushed the feat/navbar-vertical-tooltip-override branch 2 times, most recently from 4ed4bd1 to 447f7f1 Compare July 15, 2026 15:57
Allow consumers to override the automatic tooltip text (defaults to item
label) on collapsed navbar items via a new tooltipOverride property on
the item model. When provided, the tooltip is also enabled in the
expanded state so it can be shown whenever needed.
@spike-rabbit
spike-rabbit force-pushed the feat/navbar-vertical-tooltip-override branch from 447f7f1 to d1124e8 Compare July 16, 2026 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant