feat(navbar-vertical): add tooltipOverride to items#2352
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a tooltipOverride property to vertical navbar items, allowing custom tooltip text to be displayed instead of the default item label. The review feedback highlights a potential issue where an empty string for tooltipOverride would still render an empty tooltip when collapsed, violating repository guidelines; it suggests explicitly disabling the tooltip in this scenario. Additionally, the feedback recommends updating the JSDoc documentation to accurately describe that the tooltip override is active in both expanded and collapsed states.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
4ed4bd1 to
447f7f1
Compare
Allow consumers to override the automatic tooltip text (defaults to item label) on collapsed navbar items via a new tooltipOverride property on the item model. When provided, the tooltip is also enabled in the expanded state so it can be shown whenever needed.
447f7f1 to
d1124e8
Compare
Allow consumers to override the automatic tooltip text (defaults to item label) on collapsed navbar items via a new
tooltipOverrideproperty on the item model. When provided, the tooltip is also enabled in the expanded state so it can be shown whenever needed.Changes
tooltipOverride?: TranslatableStringtoNavbarVerticalItemBase[siTooltip]bindings to useitem.tooltipOverride ?? item.label[isDisabled]so tooltip stays enabled in expanded state whentooltipOverrideis providedDocumentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: