refactor(icon-legacy): remove deprecated component - #2324
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes the deprecated SiIconLegacyComponent along with its associated tests, templates, and migration test data. The reviewer noted that the corresponding symbol renaming rule in SYMBOL_RENAMING_MIGRATION should also be removed to prevent incorrect migrations that could break consumer builds.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
|
||
| const ELEMENT_SELECTORS_MIGRATION: ElementSelectorInstruction[] = [ | ||
| // current to legacy | ||
| { replace: 'si-icon', replaceWith: 'si-icon-legacy' }, |
There was a problem hiding this comment.
Since SiIconLegacyComponent is being completely removed, the corresponding symbol renaming rule in SYMBOL_RENAMING_MIGRATION (which renames SiIconComponent to SiIconLegacyComponent) should also be removed. Leaving that rule active will cause valid SiIconComponent imports to be incorrectly migrated to the deleted legacy component, breaking consumer builds. Please clean up the obsolete symbol renaming rule in SYMBOL_RENAMING_MIGRATION as well.
|
@spike-rabbit Can we potentially provide a schematic instead of blindly deleting the component? |
|
I add all those PR to #2268. Then we can discuss there if we will add schematics. I guess for this one we can probably provide one. |
Thanks, I will list my other PRs there. |
ec40aa4 to
7d8fdca
Compare
BREAKING CHANGE: Removed component `SiIconLegacyComponent`. Use `SiIconComponent` instead.
7d8fdca to
3dc12ab
Compare
|
Moved to v52.0.0 because we also still use it in our own internal libs. We should first write the migration scripts and migrate our own components before we remove it in element. |
BREAKING CHANGE: Removed component
SiIconLegacyComponent. UseSiIconComponentinstead.Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: