Skip to content

refactor(icon-legacy): remove deprecated component - #2324

Draft
akashsonune wants to merge 1 commit into
mainfrom
refactor/remove-deprecated-icon-legacy
Draft

refactor(icon-legacy): remove deprecated component#2324
akashsonune wants to merge 1 commit into
mainfrom
refactor/remove-deprecated-icon-legacy

Conversation

@akashsonune

@akashsonune akashsonune commented Jul 13, 2026

Copy link
Copy Markdown
Member

BREAKING CHANGE: Removed component SiIconLegacyComponent. Use SiIconComponent instead.


Documentation.
Examples.
Dashboards Demo.
Playwright report.

Coverage Reports:

Code Coverage

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the deprecated SiIconLegacyComponent along with its associated tests, templates, and migration test data. The reviewer noted that the corresponding symbol renaming rule in SYMBOL_RENAMING_MIGRATION should also be removed to prevent incorrect migrations that could break consumer builds.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.


const ELEMENT_SELECTORS_MIGRATION: ElementSelectorInstruction[] = [
// current to legacy
{ replace: 'si-icon', replaceWith: 'si-icon-legacy' },

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since SiIconLegacyComponent is being completely removed, the corresponding symbol renaming rule in SYMBOL_RENAMING_MIGRATION (which renames SiIconComponent to SiIconLegacyComponent) should also be removed. Leaving that rule active will cause valid SiIconComponent imports to be incorrectly migrated to the deleted legacy component, breaking consumer builds. Please clean up the obsolete symbol renaming rule in SYMBOL_RENAMING_MIGRATION as well.

@akashsonune akashsonune added the breaking-changes Marks issues and PRs that are breaking the API label Jul 14, 2026
@akashsonune akashsonune added this to the 51.0.0 milestone Jul 14, 2026
@spliffone

Copy link
Copy Markdown
Member

@spike-rabbit Can we potentially provide a schematic instead of blindly deleting the component?

@spike-rabbit

Copy link
Copy Markdown
Member

I add all those PR to #2268. Then we can discuss there if we will add schematics. I guess for this one we can probably provide one.

@akashsonune

Copy link
Copy Markdown
Member Author

I add all those PR to #2268. Then we can discuss there if we will add schematics. I guess for this one we can probably provide one.

Thanks, I will list my other PRs there.

@akashsonune
akashsonune force-pushed the refactor/remove-deprecated-icon-legacy branch 2 times, most recently from ec40aa4 to 7d8fdca Compare July 16, 2026 08:18
BREAKING CHANGE: Removed component `SiIconLegacyComponent`. Use `SiIconComponent` instead.
@akashsonune
akashsonune force-pushed the refactor/remove-deprecated-icon-legacy branch from 7d8fdca to 3dc12ab Compare July 16, 2026 08:53
@kfenner kfenner modified the milestones: 51.0.0, 52.0.0 Jul 20, 2026
@kfenner

kfenner commented Jul 20, 2026

Copy link
Copy Markdown
Member

Moved to v52.0.0 because we also still use it in our own internal libs. We should first write the migration scripts and migrate our own components before we remove it in element.

@kfenner kfenner modified the milestones: 52.0.0, 51.x, 51.0.0 Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-changes Marks issues and PRs that are breaking the API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants