Skip to content

refactor(tabs-legacy): remove deprecated component - #2322

Draft
akashsonune wants to merge 1 commit into
mainfrom
refactor/remove-deprecated-tabs-legacy
Draft

refactor(tabs-legacy): remove deprecated component#2322
akashsonune wants to merge 1 commit into
mainfrom
refactor/remove-deprecated-tabs-legacy

Conversation

@akashsonune

@akashsonune akashsonune commented Jul 13, 2026

Copy link
Copy Markdown
Member

BREAKING CHANGE: Removed components SiTabLegacyComponent and SiTabsetLegacyComponent. Use the new components from @siemens/element-ng/tabs instead.


Documentation.
Examples.
Dashboards Demo.
Playwright report.

Coverage Reports:

Code Coverage

BREAKING CHANGE: Removed components `SiTabLegacyComponent` and `SiTabsetLegacyComponent`. Use the new components from `@siemens/element-ng/tabs` instead.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request completely removes the legacy tabs component (tabs-legacy) and all of its associated files, including components, modules, styles, templates, tests, documentation exports, and sample components. I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@akashsonune akashsonune added the breaking-changes Marks issues and PRs that are breaking the API label Jul 14, 2026
@akashsonune akashsonune added this to the 51.0.0 milestone Jul 14, 2026
@dr-itz

dr-itz commented Jul 15, 2026

Copy link
Copy Markdown
Member

Can we wait with that? In TV this is still used and cannot currently be replaced, see the MR there. If we have #2347 solved (with backport in v49), I could probably fix up the rest and unblock this

@akashsonune

Copy link
Copy Markdown
Member Author

Can we wait with that? In TV this is still used and cannot currently be replaced, see the MR there. If we have #2347 solved (with backport in v49), I could probably fix up the rest and unblock this

I think we should wait then. @spike-rabbit WDYT?

@spike-rabbit

Copy link
Copy Markdown
Member

sure, then lets move it backward

@spike-rabbit

Copy link
Copy Markdown
Member

But let me try to fix #2347

@kfenner kfenner modified the milestones: 51.0.0, 52.0.0 Jul 20, 2026
@kfenner

kfenner commented Jul 20, 2026

Copy link
Copy Markdown
Member

Moved it to v52.0.0

@kfenner kfenner modified the milestones: 52.0.0, 51.x Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-changes Marks issues and PRs that are breaking the API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants