chore(dashboards-demo): add rootDir to resolve TypeScript path mapping errors - #2319
Open
chintankavathia wants to merge 1 commit into
Open
chore(dashboards-demo): add rootDir to resolve TypeScript path mapping errors#2319chintankavathia wants to merge 1 commit into
chintankavathia wants to merge 1 commit into
Conversation
…g errors Set rootDir to '../..' in tsconfig.app.json to allow imports from @siemens/element-ng/* and other library packages via path mappings without triggering 'not under rootDir' TypeScript errors.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the TypeScript configuration for the dashboards-demo application (tsconfig.app.json) by adding the rootDir property set to "../.." under compilerOptions. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
chintankavathia
marked this pull request as ready for review
July 13, 2026 10:57
Member
|
According to https://devblogs.microsoft.com/typescript/announcing-typescript-7-0/ can also just set an input instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set rootDir to '../..' in tsconfig.app.json to allow imports from @siemens/element-ng/* and other library packages via path mappings without triggering 'not under rootDir' TypeScript errors.
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: