feat(maplibre): provide basic theme for maplibre - #2029
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces MapLibre integration into the @siemens/element-ng library, providing theme-aware style specifications and Angular signal-based utilities for map state management. Feedback focused on improving visual hierarchy through specific font weights, removing redundant dependency injections, and ensuring consistent UX by adjusting cursors for disabled elements. Additionally, several hardcoded color values in the SCSS files should be replaced with Siemens Element semantic tokens to maintain theme consistency.
3030ff8 to
1ff5366
Compare
120f45c to
e8d42d1
Compare
kfenner
added
the
core-team-discussion
938da06 to
5a3ca9c
Compare
|
@kfenner @timowolf @dr-itz So which direction shall we go, shall we keep it as it is or do we want to move everything into '@siemens/maps-ng' which would mean we need to relaxe the dependencies and it requires multiple entry points. (I guess that we be breaking) I would prefer to keep it in '@siemens/element-ng' since we did the same for other dependencies e.g. ag-grid too. |
1a57571 to
03aae8a
Compare
kfenner
removed
the
core-team-discussion
74cf465 to
d5a664c
Compare
spliffone
added
the
core-team-discussion
089760c to
db36b98
Compare
15c3769 to
b087b01
Compare
b3f8ce7 to
94cd4f0
Compare
spike-rabbit
left a comment
spike-rabbit
left a comment
There was a problem hiding this comment.
@dr-itz can you please have a look here? For me it looks good beside the small comment.
94cd4f0 to
404a906
Compare
| .maplibregl-ctrl-scale { | ||
| @extend %base-control; | ||
|
|
||
| font-size: 10px; |
There was a problem hiding this comment.
That's not possible, maplibre calculate the width and apply the width via styles see
There was a problem hiding this comment.
but that's the width of the scale. I tried 0.625rem and it works fine for me. It's correctly aligned and I don't see overlaps or anything
There was a problem hiding this comment.
I was thinking the same, but then played with the zoom level and it looks like this:
kfenner
removed
the
core-team-discussion
83d39f3 to
6fa6202
Compare
b342f43 to
5fe5564
Compare
4 participants
Provide an experimental styling for maplibre and provide the ground for further features e.g. 3d buildings, localization, marker, cluster support...
See also #829
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: