Fix provided scope warnings for Maven plugin dependencies#526
Open
xjusko wants to merge 1 commit intoshrinkwrap:masterfrom
Open
Fix provided scope warnings for Maven plugin dependencies#526xjusko wants to merge 1 commit intoshrinkwrap:masterfrom
xjusko wants to merge 1 commit intoshrinkwrap:masterfrom
Conversation
Set Maven API dependencies to provided scope in the maven-plugin module, as they are supplied by the Maven runtime when executing the plugin.
Contributor
Author
|
I am not 100% sure we want to go through with this change. It creates clutter in the code; however, in the past, we encountered some issues with dependencies where the provided scope was missing. |
Member
|
Do we use all of those dependencies? |
Contributor
Author
|
@petrberan The plugin code uses maven-plugin-api, maven-core, and maven-model directly via imports. The remaining 7 are transitive from shrinkwrap modules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set Maven API dependencies to provided scope in the maven-plugin module, as they are supplied by the Maven runtime when executing the plugin.
fixes #520