-
Notifications
You must be signed in to change notification settings - Fork 0
[app] Graceful shutdown consistency (grace periods and preStop alignment) #36
Copy link
Copy link
Open
Labels
area/app-chartshopsys-app chart (workloads, ingresses, secrets, hooks)shopsys-app chart (workloads, ingresses, secrets, hooks)area/infra-chartshopsys-infra chart (Redis, RabbitMQ, RBAC)shopsys-infra chart (Redis, RabbitMQ, RBAC)behavior-changechanges rendered manifests - regenerate golden snapshots + update deviations docchanges rendered manifests - regenerate golden snapshots + update deviations docenhancementNew feature or requestNew feature or requestpriority/medium
Description
Activity
Metadata
Metadata
Assignees
Labels
area/app-chartshopsys-app chart (workloads, ingresses, secrets, hooks)shopsys-app chart (workloads, ingresses, secrets, hooks)area/infra-chartshopsys-infra chart (Redis, RabbitMQ, RBAC)shopsys-infra chart (Redis, RabbitMQ, RBAC)behavior-changechanges rendered manifests - regenerate golden snapshots + update deviations docchanges rendered manifests - regenerate golden snapshots + update deviations docenhancementNew feature or requestNew feature or requestpriority/medium
Context
Grace periods and preStop hooks are inconsistent across workloads:
sleep 10; kill -QUIT 1request_terminate_timeout)sleep 5 && nginx -s quitsleep 10Proposal
Align (all as component values, these become the defaults):
90(10 drain + 60 worker timeout + buffer)sleep 10 && nginx -s quit(same LB-drain window as php-fpm)3060+ preStopredis-cli SHUTDOWN NOSAVE(ephemeral cache — NOSAVE)Cron and RabbitMQ are handled in #25 and #6 respectively — keep this issue to the four above.
Tasks