Skip to content

[app] Run cache warmup as an init container instead of postStart (port of deployment#73) #26

Description

@henzigo

Context

The php-fpm container warms the application cache in a postStart hook
(phing -S warmup). postStart failures are hard to observe, run concurrently with the
container's main process, and the pod can become Ready before the warmup finished.

Upstream PR shopsys/deployment#73 moves the warmup into a dedicated init container
(same image, same env, shared source-codes volume + domains-urls mount) and drops the
postStart hook.

Proposal

Port the same change into deployment-webserver-php-fpm.yaml:

Benefits: warmup failures fail the rollout visibly (init container status), readiness is
truthful, logs are separated.

Tasks

  • Warmup init container + postStart removal
  • Unit test, golden snapshots, deviations entry
  • Verify rollout timing impact (warmup now serializes before containers start)

Reference: shopsys/deployment#73

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/app-chartshopsys-app chart (workloads, ingresses, secrets, hooks)behavior-changechanges rendered manifests - regenerate golden snapshots + update deviations docenhancementNew feature or requestpriority/medium

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions