Repository navigation
Conversation
Co-Authored-By: Claude Code Claude-Session: https://claude.ai/code/session_01EgBNLXJxaNgQLSU3aEeTb2
There was a problem hiding this comment.
🟢 Approval recommended
The narrowly scoped matrix addition reuses the existing CI configuration, with no blocking issues identified.
No open issues 🎉
What changed in this PR
Adds PHP 8.6 to the existing CI matrix to test compatibility alongside PHP 8.1–8.5.
Changes:
- Includes PHP 8.6 on Ubuntu and Windows with both lowest and stable dependency configurations.
| File | Description |
|---|---|
.github/workflows/checks.yml |
Adds PHP 8.6 to the test matrix without changing existing test steps. |
Review effort: Balanced
Co-Authored-By: Claude Code Claude-Session: https://claude.ai/code/session_01EgBNLXJxaNgQLSU3aEeTb2
Co-Authored-By: Claude Code Claude-Session: https://claude.ai/code/session_01EgBNLXJxaNgQLSU3aEeTb2
This reverts commit faf612f. Not needed anymore: ergebnis/composer-normalize was the only dependency that did not allow PHP 8.6. Co-Authored-By: Claude Code Claude-Session: https://claude.ai/code/session_01EgBNLXJxaNgQLSU3aEeTb2
Co-Authored-By: Claude Code Claude-Session: https://claude.ai/code/session_01EgBNLXJxaNgQLSU3aEeTb2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds PHP 8.6 (currently RC) to the CI test matrix.
Replaces
ergebnis/composer-normalizewithshipmonk/composer-normalizer.ergebnis/composer-normalize(throughlocalheinz/diff) does not allow PHP 8.6 yet, so composer could not install the dependencies in the PHP 8.6 jobs. The new tool is not a Composer plugin and has no dependencies;check:composernow runscomposer-normalizer --dry-run. New scripts:fix:composerrunscomposer-normalizer, andfixrunsfix:composerandfix:cs.Co-Authored-By: Claude Code
https://claude.ai/code/session_01EgBNLXJxaNgQLSU3aEeTb2