Repository navigation
ForbidCheckedExceptionInCallableRule: resolve static call caller type from expressions - #368
Merged
janedbal merged 2 commits intoSep 17, 2026
Conversation
… from expressions Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…lbacksA6 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
maryo
marked this pull request as ready for review
August 28, 2026 12:49
Member
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a static method is called on anything but a literal class name, the rule ignores
@param-immediately-invoked-callableon the target parameter (andallowedCheckedExceptionCallablesas well) and reports the callable anyway. Both an object and a class-string in the class part are affected:Both
whitelistAllowedCallables()andprocessFirstClassCallable()guarded theirStaticCallbranch by$node->class instanceof Name. They now resolve the caller type through the scope, the way theMethodCallbranch already does;getObjectTypeOrClassStringObjectType()covers objects and class-strings alike. Anything else resolves toErrorType, finds no method reflection and behaves as before.Note for the release notes: fixing the missing report can surface new errors on
$expr::methodWithThrows(...)in existing codebases.The second commit is unrelated —
FirstClassCallableTestdeclaredtestPassedCallbacksA6twice, so the data file could not be loaded (tests/Rule/datais in the composer classmap).🤖 Generated with Claude Code