Repository navigation
Replace the Makefile with elk:* mise tasks - #133
Merged
Merged
Conversation
sherifabdlnaby
added this pull request to stack #134
September 25, 2026 15:02
sherifabdlnaby
force-pushed
the
2-makefile-to-mise
branch
from
September 25, 2026 15:04
b1fbd4d to
ef17e7a
Compare
The combined groups repeated every service name, so adding a service meant editing it in several places.
The stack commands are now only mise tasks, grouped under the `elk:` namespace so `mise tasks` lists them together. The bare `elk` starts the core stack. Each task runs the same compose files, flags, and services as the make target it replaces. The README has an old-to-new command table. BREAKING CHANGE: the Makefile is removed and running the stack needs mise. The earlier flat mise task names (`up`, `stack:setup`, `down`, ...) are renamed to `elk`, `elk:setup`, `elk:down`, ...
sherifabdlnaby
force-pushed
the
2-makefile-to-mise
branch
from
September 25, 2026 15:05
ef17e7a to
30d1e02
Compare
sherifabdlnaby
removed this pull request from stack #134
September 25, 2026 15:05
elk:setup now runs mise doctor project first, so a missing Docker engine or Compose plugin stops it with a fix hint instead of a raw compose error. The hints no longer point at the contributor setup task.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes
The stack had two interfaces: a deprecated
Makefileand flat mise tasks (up,stack:setup, ...). Now it has one: mise tasks under theelk:namespace. TheMakefileis removed, and running the stack needs mise.Warning
Breaking:
make <target>no longer works, and the flat mise task names from #128 are renamed. Install mise (README, Requirements), runmise trustonce, then use the new names below.make setup/mise run stack:setupmise run elk:setupmake certs/mise run certsmise run elk:certsmake keystore/mise run keystoremise run elk:keystoremake upgrade-keystore/mise run upgrade-keystoremise run elk:keystore:upgrademake elk,make up/mise run upmise run elkmake all/mise run allmise run elk:allmake monitoring/mise run monitoringmise run elk:monitoringmake nodes/mise run nodesmise run elk:nodesmake collect-docker-logs/mise run collect-docker-logsmise run elk:collect-docker-logsmake build/mise run buildmise run elk:buildmake ps/mise run psmise run elk:psmake images/mise run imagesmise run elk:imagesmake logs/mise run logsmise run elk:logsmake stop/mise run stopmise run elk:stopmake restart/mise run restartmise run elk:restartmake down/mise run downmise run elk:downmake rm/mise run rmmise run elk:rmmake prune/mise run prunemise run elk:prunemake helpmise tasksChanges
mise tasks, underelk:. The bareelkstarts the core stack.elk:setuprunsmise doctor projectfirst, so a missing Docker engine or Compose plugin stops it with a fix hint instead of a raw compose error.elk:rmandelk:pruneask for confirmation (mise run -y ...skips it), as the mise tasks already did.mise trust, every command uses the new names, and a Moving frommakesection has the table above.[vars]are built from their parts instead of repeating every service name.Review guide
mise.toml, ELK stack section: the renamed tasks.elk:setupnow callselk:certsandelk:keystoreinstead of repeating their commands.README.md: Requirements, Setup, Additional Commands, Moving frommake.AGENTS.md,.github/workflows/smoke-test.yml,.gitattributes,services.sh: follow-on renames, safe to skim.Decisions
elk:namespace for every stack task over top-levelmonitoring/nodes/build: one prefix keeps the stack apart from the contributor tasks (setup,check,test) inmise tasks, andmise run elk:<TAB>completes the full set.elk:keystore:upgradeoverelk:upgrade-keystore: it sits underelk:keystore, the task it upgrades.up,down, ... as aliases: this is a breaking change on purpose, and aliases would keep two names alive.setupas the contributor toolchain setup over foldingelk:setupinto it:elk:setupstarts containers and regenerates secrets, which does not belong in a per-worktree bootstrap.Does this close any currently open issues?
No.
Any relevant logs, error output, etc?
None.
Any other comments?
The release drafter bumps the major version on the
majorlabel, so this PR has it.Follow-ups / out of scope
mise run setupstill gets the "setup is stale" nag oncd(withmise activate). A stack-only user does not need the linters, so that nag could be scoped to contributors.Where has this been tested?
Verification
Automated:
mise run check --allpasses.mise taskslists everyelk:*task with a description.Manual: Recorded
make -n <target>for every target before the delete, then ran each new task with a stubdockerthat prints its arguments. Every resolveddocker composecommand matches its make target (same files, flags, services).mise run elk:logs kibana logstashpasses only those services.Not covered: The stack was not started locally; the Smoke Test workflow covers
elk:setup+elk. The other start tasks (elk:all,elk:nodes, ...) were compared by command only.Relevant Links
馃 Agent Decided PR: Created with Claude (Opus 5.5) on behalf of @sherifabdlnaby.
馃 Generated with Claude Code