ci(review): pair the review with a matching claude branch - #7075
Merged
Conversation
The claude checkout took the default branch, so a change to the review procedure could not be exercised by the pull request that proposes it: the workflow read the procedure from master, where the change is not yet. The sibling code repo already resolves a same-named branch this way.
Code Review CompleteThe automated review ran but did not post an updated summary — this usually means no new issues were found since the previous review. If you've pushed changes and want a fresh pass, comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
clauderepo checkout in the review workflow now resolves a branch with the same name as the PR head, falling back to master — the pattern the sibling code-repo checkout already uses.Why
The review procedure lives in
shellhub-io/claude, and the checkout took its default branch. A PR that changes the procedure therefore could not exercise the change: the workflow read the version on master. That is how shellhub-io/cloud#2544 failed its own review run — theLoad review procedurestep errored because the file only existed on the paired branch.Testing
This PR has no paired
claudebranch, so the step resolves to master and the review runs as before. Pair a branch by name inshellhub-io/claudeto see the other path taken.