Skip to content

docs: refresh CONTRIBUTING with the real dev workflow - #88

Closed
aryansk wants to merge 1 commit into
shauryagangrade:mainfrom
aryansk:codex/issue-73-contributing
Closed

docs: refresh CONTRIBUTING with the real dev workflow#88
aryansk wants to merge 1 commit into
shauryagangrade:mainfrom
aryansk:codex/issue-73-contributing

Conversation

@aryansk

@aryansk aryansk commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Problem

CONTRIBUTING.md describes pip install -e . only and says nothing about the
actual stack: uv sync, ruff, mypy, bandit, the CI matrix, or how to add a
new tool/slash command. New contributors can't validate their work locally
without reverse-engineering CI. Closes #73.

Change

Rewrites CONTRIBUTING.md to match the real dev workflow:

  • uv sync --extra dev setup with a pointer to the Windows guide.
  • The exact commands CI runs (ruff check, ruff format --check,
    mypy gcode, bandit, compileall, pytest) and the Python
    3.10–3.13 matrix note.
  • An end-to-end checklist for adding an agent tool (gcode/tools.py,
    ALL_TOOLS, TOOL_MAP, tests) and one for adding a slash command
    (gcode/cli.py handler, _SLASH_COMMANDS in gcode/ui.py,
    _print_help, README Commands list, tests).
  • Correct issue-template links (bug_report.yml, feature_request.yml).

Why this approach

Docs-only, no behavior change. The checklists were verified against the
current source (tools.py, ui.py, cli.py, ci.yml) so a newcomer can go from
clone to green local checks using the doc alone.

Testing

  • git diff --check clean.
  • Every internal link/anchor verified against the repo tree
    (README #setup/#use, .github/ISSUE_TEMPLATE/*.yml, docs/windows.md).
  • Commands mirror .github/workflows/ci.yml exactly.

Documentation and release impact

  • User-facing documentation updated
  • Changelog/release note needed
  • Migration or compatibility note needed
  • No documentation impact

Review notes

  • Known limitations: none.
  • Merge note: draft PR chore: add pre-commit config mirroring the CI lint job #85 (pre-commit config) also edits CONTRIBUTING.md
    (adds a Pre-commit Hooks section); this PR fully rewrites the file. If both
    merge, a small rebase on CONTRIBUTING.md is needed — happy to do it.
  • Follow-up issue: none.

Documents uv sync --extra dev setup, the exact commands CI runs (ruff,
mypy, bandit, compileall, pytest), and end-to-end checklists for adding
an agent tool or a slash command. Closes shauryagangrade#73.

@shauryagangrade shauryagangrade left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great refresh — this brings CONTRIBUTING in line with reality. I verified every command against the actual CI workflow (.github/workflows/ci.yml): uv sync --extra dev, ruff check ., ruff format --check ., mypy gcode, bandit -q -r gcode/ -c pyproject.toml, compileall gcode demo, pytest — all exact matches. The new tool/slash-command walkthroughs match the real code layout (gcode/tools.py, ALL_TOOLS, TOOL_MAP, _SLASH_COMMANDS, _print_help).

Notes (non-blocking):

  • Cross-PR dependency: it links to docs/windows.md, which only exists in #87 — merge #87 first.
  • The template references were updated to .yml (bug_report.yml, feature_request.yml), which exist in .github/ISSUE_TEMPLATE/ — correct.
  • Tiny nit: the PR checklist lines dropped their trailing periods ("documented (this checklist above)"); trivial formatting.

Approve — ready once you mark the PR ready for review.

@github-actions

Copy link
Copy Markdown

Hi @aryansk, thanks for the PR! It references #73, which is reserved for first-time contributors. Since you've already contributed here, please work on a different, unreserved issue instead. Closing without merging. Thanks!

@github-actions github-actions Bot closed this Aug 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Docs]: Refresh CONTRIBUTING.md with the real dev workflow

2 participants