Tests: Add a new user with home directory creation

[aborah-sudo]

This is the transformation to Python of the test located in tests/usertools/01/17_useradd_create_homedir.test which checks that useradd can add a new user with --create-home

Implement CREATE_HOME is set to no

[ikerexxe]

Hi Anuj,

First, let’s get those framework changes moved into their own separate commit! We need to keep the framework evolution isolated from the test logic to keep our git history clean and easy to audit.

On the technical side:

• Simplify the logic by removing self.host.discard_file() for /etc/login.defs. Changes to that specific file don’t actually impact the test results, so there's no need for the extra overhead.
• The current implementation relies on some hacks that won't scale well. We need a more robust approach that handles its own cleanup. Check out the SSSD implementation here for inspiration. I’m expecting a similar pattern where we can call something like shadow.login_defs("CREATE_HOME") = "no". This will keep the code clean.
• Right now, your configuration changes are leaking into the next tests. Please ensure the implementation includes a proper teardown mechanism (like the SSSD framework does) so that every test starts with a fresh, predictable environment.

[ikerexxe]

The current implementation creates LoginDefsConfig in a way that bypasses pytest-mh's automatic lifecycle management.

The LoginDefsConfig is stored as self._login_defs (with leading underscore) and created lazily via @property. This means:

• pytest-mh's metaclass ignores it (leading underscore signals "private")
• setup() is never called automatically → no backup is created
• teardown() must be called manually → error-prone and inconsistent

Changes needed:

1. Remove the @property and _login_defs attribute
2. Create the utility in __init__ with no leading underscore
3. Use .postpone_setup() for lazy initialization -> self.login_defs: LoginDefsConfig = LoginDefsConfig(self.host).postpone_setup()
4. Remove the manual self._login_defs.teardown() call from Shadow.teardown()

This gives you the same clean API (shadow.login_defs["key"] = "value") but with automatic framework-managed lifecycle. Look at how other utilities like self.fs, self.firewall etc. are integrated in BaseLinuxRole.__init__.

The SSSD framework uses this same pattern - utilities are discovered and managed automatically by the framework, not manually by each role.

[ikerexxe]

Just some comments inline

[ikerexxe]

We are almost there. Apart from the inline comment you should also improve the commit message for the LoginDefsConfig implementation. What about:

tests: implement login.defs configuration utility                                                 
                                                                                                    
Introduce LoginDefsConfig class for /etc/login.defs manipulation.
It supports getting, setting, and removing configuration options
with automatic backup and restoration.

In addition, let's invert the commits as the test requires the framework changes to be there before.

[ikerexxe]

This message is a bit misleading as we are focusing on the creation with --create-home. What about using Home directory {home_dir} should exist when using --create-home flag or Expected home directory {home_dir} to be created by --create-home?