feat: 갤러리 드래그 다중 선택을 Google Photos 스타일 range 선택으로 변경 - #2
Merged
Conversation
- anchor(롱프레스 시작 지점)~현재 손가락 위치 사이 range를 매 tick마다 baseline 기준으로 재계산하도록 변경. - 기존에는 스크롤 중 손가락이 위치한 셀 하나만 선택되던 문제를 해결하고, 방향 반전 시 range 밖 항목이 자동 해제되도록 함. 이미 선택된 셀에서 드래그를 시작하면 해제 모드로 동작.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (19)
Walkthrough갤러리 드래그 선택을 개별 토글에서 인덱스 기반 범위 선택으로 변경하고, 앨범 로딩 상태와 선택 제한 처리를 추가했습니다. 이미지 모델은 Parcelable을 지원하며, PickerHost 상태 복원과 ViewModel 단위 테스트 및 테스트 인프라가 확장되었습니다. Changes갤러리 선택 흐름
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant GalleryScreen
participant photoGridDragHandler
participant GalleryScreenViewModel
GalleryScreen->>photoGridDragHandler: 드래그 위치와 이미지 스냅샷 전달
photoGridDragHandler->>GalleryScreen: 드래그 범위 인텐트 디스패치
GalleryScreen->>GalleryScreenViewModel: BeginDragSelection / UpdateDragSelectionRange
GalleryScreenViewModel->>GalleryScreenViewModel: 기준 선택과 범위 선택 계산
GalleryScreenViewModel->>GalleryScreen: selectedImages 상태 및 선택 제한 효과 반환
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
새로운 기능
개선 사항