Fix mozjs_sys prebuilt library#756
Merged
Merged
Conversation
The windows-latest image was upgraded to VS 2026 in June, which seems to cause linking errors when attempting to link the VS 2026 prebuilt library into servo (built in CI with VS 2022). Pin the old image instead, to stay in sync with servo. Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
jschwe
force-pushed
the
fix_prebuilt_mozjs
branch
from
78251ad to
4ec91e1
Compare
sagudev
approved these changes
Jun 12, 2026
sagudev
left a comment
sagudev
left a comment
Member
There was a problem hiding this comment.
I guess there is no backwards compatibility, but is there at least forward compatibility or does that one also breaks? If so we should do some MSVC detection in build script and fallback to build when MSVC from prebuilds does not match.
Member
Author
|
I'm not sure, but I would hope so. Can we test that after merging this PR, by doing a try run in servo (fork) with windows-latest? Not sure how to test it easily before the release. |
Member
Author
|
https://learn.microsoft.com/en-us/cpp/porting/binary-compat-2015-2017?view=msvc-180 Seems that as long as the linker is newer than the newest used toolchain, artifacts can be combined, so we should be good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The windows-latest image was upgraded to VS 2026 in June, which seems to cause linking errors when attempting to link the VS 2026 prebuilt library into servo (built in CI with VS 2022). Pin the old image instead, to stay in sync with servo.
Testing: This will need a prebuilt library first, before we can test this in servo, since build from source doesn't reproduce the problem.