Improve verbosity for log output#671
Open
jaydrogers wants to merge 2 commits intorelease/webserver-improvements-and-fixesfrom
Open
Improve verbosity for log output#671jaydrogers wants to merge 2 commits intorelease/webserver-improvements-and-fixesfrom
jaydrogers wants to merge 2 commits intorelease/webserver-improvements-and-fixesfrom
Conversation
- Updated the `LOG_OUTPUT_LEVEL` description in the documentation to clarify verbosity levels and their impact on logging behavior. - Modified the entrypoint script to remove unnecessary checks for `LOG_OUTPUT_LEVEL` when displaying container info. - Added checks in the SSL generation script to conditionally log messages based on the `LOG_OUTPUT_LEVEL`, improving debugging capabilities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What PR Does
Fix
SERVERSIDEUP_DEFAULT_COMMANDfor FrankenPHPFrankenPHP's default CMD (
frankenphp run ...) was not recognized as a default server command. This meant any logic gated behindSERVERSIDEUP_DEFAULT_COMMANDsilently skipped for FrankenPHP containers. Added"frankenphp"to the case match alongside/initandphp-fpm.Skip SSL script for non-server commands
Running
docker compose run php composer installon a web server variation (fpm-nginx, fpm-apache, frankenphp) no longer prints SSL-related messages or generates certificates. The SSL script now exits early when the container is not starting its primary server process. Informational messages like "SSL mode is off" and "certs already exist" are now debug-only — errors and cert generation confirmations remain visible.Remove broken
offvalue fromLOG_OUTPUT_LEVELThe value
offwas documented and partially handled in the container info script, but1-log-output-level.shrejected it — stopping the container. Removed the deadoffcheck. UseSHOW_WELCOME_MESSAGE=falseto suppress the welcome banner instead.Fix FrankenPHP address-level debug log
When
LOG_OUTPUT_LEVEL=debug, the per-site (address) Caddy log was defaulting toINFOinstead ofDEBUG. Now matches the global debug snippet.Update
LOG_OUTPUT_LEVELdocumentationdebug,info,notice,warn,error,crit,alert,emerginfo(Caddy unifies access and error logs —warnsuppresses HTTP request logs entirely)