test(core): Reproduce chained StringBuilder.append taint loss#230
Open
misonijnik wants to merge 9 commits into
Open
test(core): Reproduce chained StringBuilder.append taint loss#230misonijnik wants to merge 9 commits into
misonijnik wants to merge 9 commits into
Conversation
Saloed
force-pushed
the
misonijnik/append-chain-issue
branch
from
944f51b to
f419ce2
Compare
Add StringBuilderChainDataFlowSample and five
JavaDataFlowReachabilityTest
cases mirroring the table in issue.md. A chained sb.append(A).append(B)
whose
result is discarded does not propagate B onto the original sb, so a
later
sb.toString() read off the original receiver loses the taint: append's
arg(0) -> this lands on the intermediate return object, never back on
sb.
chainedAppend and namedReturn currently FAIL ("expected taint to reach
the
sink, but no vulnerability was found") -- these two are the
reproduction.
unchained, chainTaintFirst, and sinkChainResult pass and pin the working
single-append / chain-end paths that a fix must not regress.
Saloed
force-pushed
the
misonijnik/append-chain-issue
branch
from
f419ce2 to
0b26750
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.