Guard against negative array size in MainActivity - #273
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
The 'negative_index' button allocated `new int[-5]`, which always threw an unhandled NegativeArraySizeException and crashed the app on tap. Validate the requested size before allocating and report the invalid size to Sentry as a handled event instead of crashing. Fixes [ANDROID-NG](https://demo.sentry.io/issues/7734837700/)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #273 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 16 16
Lines 883 887 +4
Branches 67 68 +1
=====================================
- Misses 883 887 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was triggered by a Seer handoff from Sentry.
Root cause: The click listener for the
negative_indexbutton inMainActivityallocatednew int[-5]directly. Java rejects negative array sizes, so every tap threw an unhandledNegativeArraySizeExceptionand crashed the app.Solution: The requested array size is now held in a variable and validated before the allocation. If it is negative, the listener reports an
IllegalArgumentExceptionto Sentry as a handled event (consistent with the other handled-error buttons) and returns without allocating, so the app no longer crashes.Fixes ANDROID-NG