[UIK-5273][theme] Add page-bg variable#2985
Draft
j-mnizhek wants to merge 4 commits into
Draft
Conversation
ilyabrower
reviewed
Jun 5, 2026
| header_border_secondary: { value: '{semanticTokens.colors.border.primary}' }, | ||
| page_bg: { value: neutral.at(0.97), | ||
| description: 'Background fill for the whole product page.', | ||
| }, |
Contributor
There was a problem hiding this comment.
what do you think about adding sidebar_nav_bg?
Member
Author
There was a problem hiding this comment.
I thought about this and several additional variables for the future (screenshot from our private repo), but then we with Lesha hought that, for now, we could add only this one.
Actually I'm not strongly against these several new ones. I worry only about their usage by teams
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
@semcore/theme
Added
page-bgvariable.Changed
headergroup variables.Motivation and Context
How has this been tested?
Manually. Updated our stories for theme:
Types of changes
Checklist: