Skip to content

[UIK-4981][button] disabled if loading #2971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ilyabrower wants to merge 7 commits into
base: release/v17
Choose a base branch
from
+33 −28
Open

[UIK-4981][button] disabled if loading #2971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c8106db
[button] disabled if loading
ilyabrower May 29, 2026
2ef699c
Merge branch 'release/v17' into UIK-4981/button-loading-disabled
Valeria-Zimnitskaya Jun 4, 2026
dbd87d6
[chore] Merge remote-tracking branch 'origin/release/v17' into UIK-49…
ilyabrower Jun 4, 2026
e52ac11
[button] disabled if loading
ilyabrower Jun 4, 2026
468918b
Merge branch 'release/v17' into UIK-4981/button-loading-disabled
Valeria-Zimnitskaya Jun 5, 2026
94a40f8
[button] update test and story
Valeria-Zimnitskaya Jun 5, 2026
62d5c62
[button] update snapshots for FH
Valeria-Zimnitskaya Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 31 additions & 25 deletions semcore/button/__tests__/button.browser-test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,15 +99,15 @@ test.describe(`${TAG.VISUAL} `, () => {
});
}

if (!item.active && !item.disabled) {
if (!item.active && !item.disabled && !item.loading) {
await test.step(`Verify focus styles for not active button styles`, async () => {
await page.keyboard.press('Tab');
await locators.button(page).nth(4).hover();
await expect(page).toHaveScreenshot();
});
}

if (item.active && !item.disabled) {
if (item.active && !item.disabled && !item.loading) {
await test.step(`Verify focus styles for active button styles`, async () => {
await page.keyboard.press('Tab');
await expect(page).toHaveScreenshot();
Expand All @@ -119,6 +119,7 @@ test.describe(`${TAG.VISUAL} `, () => {
for (let i = 0; i < count; i++) {
await expect(locators.button(page).nth(i)).toHaveAttribute('aria-busy', 'true');
}
await expect(page).toHaveScreenshot();
});
}
if (item.disabled) {
Expand Down Expand Up @@ -158,15 +159,15 @@ test.describe(`${TAG.VISUAL} `, () => {
});
}

if (!item.active && !item.disabled) {
if (!item.active && !item.disabled && !item.loading) {
await test.step(`Verify focus styles for not active button styles`, async () => {
await page.keyboard.press('Tab');
await locators.button(page).nth(0).hover();
await expect(page).toHaveScreenshot();
});
}

if (item.active && !item.disabled) {
if (item.active && !item.disabled && !item.loading) {
await test.step(`Verify focus styles for active button styles`, async () => {
await page.keyboard.press('Tab');
await expect(page).toHaveScreenshot();
Expand All @@ -178,6 +179,7 @@ test.describe(`${TAG.VISUAL} `, () => {
for (let i = 0; i < count; i++) {
await expect(locators.button(page).nth(i)).toHaveAttribute('aria-busy', 'true');
}
await expect(page).toHaveScreenshot();
});
}

Expand All @@ -197,7 +199,7 @@ test.describe(`${TAG.VISUAL} `, () => {
const hint = page.locator('div[data-ui-name="Hint"]');
await locators.button(page).first().waitFor({ state: 'visible' });
await page.waitForTimeout(100);
if (!item.active && !item.disabled) {
if (!item.active && !item.disabled && !item.loading) {
await test.step(`Verify focus styles for not active button styles`, async () => {
await page.keyboard.press('Tab');
await expect(locators.button(page).first()).toBeFocused();
Expand All @@ -212,7 +214,7 @@ test.describe(`${TAG.VISUAL} `, () => {
});
}

if (item.active && !item.disabled) {
if (item.active && !item.disabled && !item.loading) {
await test.step(`Verify focus styles for active button styles`, async () => {
await locators.button(page).nth(1).hover();
await page.getByText('Hint Button Addon').waitFor({ state: 'visible' });
Expand All @@ -226,8 +228,8 @@ test.describe(`${TAG.VISUAL} `, () => {
});
}

if (item.disabled) {
await test.step(`Verify disabled styles`, async () => {
if (item.disabled || item.loading) {
await test.step(`Verify disabled / loading styles`, async () => {
await expect(page).toHaveScreenshot();
});
}
Expand Down Expand Up @@ -285,15 +287,15 @@ test.describe(`${TAG.VISUAL} `, () => {
});
}

if (!item.active && !item.disabled) {
if (!item.active && !item.disabled && !item.loading) {
await test.step(`Verify focus styles for not active button styles`, async () => {
await page.keyboard.press('Tab');
await locators.button(page).nth(4).hover();
await expect(page).toHaveScreenshot();
});
}

if (item.active && !item.disabled) {
if (item.active && !item.disabled && !item.loading) {
await test.step(`Verify focus styles for active button styles`, async () => {
await page.keyboard.press('Tab');
await expect(page).toHaveScreenshot();
Expand All @@ -305,6 +307,7 @@ test.describe(`${TAG.VISUAL} `, () => {
for (let i = 0; i < count; i++) {
await expect(locators.button(page).nth(i)).toHaveAttribute('aria-busy', 'true');
}
await expect(page).toHaveScreenshot();
});
}

Expand Down Expand Up @@ -345,15 +348,15 @@ test.describe(`${TAG.VISUAL} `, () => {
});
}

if (!item.active && !item.disabled) {
if (!item.active && !item.disabled && !item.loading) {
await test.step(`Verify focus styles for not active button styles`, async () => {
await page.keyboard.press('Tab');
await locators.button(page).nth(0).hover();
await expect(page).toHaveScreenshot();
});
}

if (item.active && !item.disabled) {
if (item.active && !item.disabled && !item.loading) {
await test.step(`Verify focus styles for active button styles`, async () => {
await page.keyboard.press('Tab');
await expect(page).toHaveScreenshot();
Expand All @@ -365,6 +368,7 @@ test.describe(`${TAG.VISUAL} `, () => {
for (let i = 0; i < count; i++) {
await expect(locators.button(page).nth(i)).toHaveAttribute('aria-busy', 'true');
}
await expect(page).toHaveScreenshot();
});
}

Expand All @@ -385,7 +389,7 @@ test.describe(`${TAG.VISUAL} `, () => {
await locators.button(page).first().waitFor({ state: 'visible' });
await page.waitForTimeout(100);

if (!item.active && !item.disabled) {
if (!item.active && !item.disabled && !item.loading) {
await test.step(`Verify focus styles for not active button styles`, async () => {
await page.keyboard.press('Tab');
await expect(locators.button(page).first()).toBeFocused();
Expand All @@ -400,7 +404,7 @@ test.describe(`${TAG.VISUAL} `, () => {
});
}

if (item.active && !item.disabled) {
if (item.active && !item.disabled && !item.loading) {
await test.step(`Verify focus styles for active button styles`, async () => {
await locators.button(page).nth(1).hover();
await page.getByText('Hint Button Addon').waitFor({ state: 'visible' });
Expand All @@ -414,8 +418,8 @@ test.describe(`${TAG.VISUAL} `, () => {
});
}

if (item.disabled) {
await test.step(`Verify disabled styles`, async () => {
if (item.disabled || item.loading) {
await test.step(`Verify disabled / loading styles`, async () => {
await expect(page).toHaveScreenshot();
});
}
Expand Down Expand Up @@ -454,7 +458,7 @@ test.describe(`${TAG.VISUAL} `, () => {
await page.keyboard.press('Tab');
const count = await locators.button(page).count();

if (!item.loading) {
if (!item.loading && !item.loading) {
await test.step('Verify text paddings and spacing based on content', async () => {
for (let i = 0; i < count; i++) {
const button = locators.button(page).nth(i);
Expand All @@ -473,15 +477,15 @@ test.describe(`${TAG.VISUAL} `, () => {
});
}

if (!item.active && !item.disabled) {
if (!item.active && !item.disabled && !item.loading) {
await test.step(`Verify focus styles for not active button styles`, async () => {
await page.keyboard.press('Tab');
await locators.button(page).nth(4).hover();
await expect(page).toHaveScreenshot();
});
}

if (item.active && !item.disabled) {
if (item.active && !item.disabled && !item.loading) {
await test.step(`Verify focus styles for active button styles`, async () => {
await page.keyboard.press('Tab');
await expect(page).toHaveScreenshot();
Expand All @@ -493,6 +497,7 @@ test.describe(`${TAG.VISUAL} `, () => {
for (let i = 0; i < count; i++) {
await expect(locators.button(page).nth(i)).toHaveAttribute('aria-busy', 'true');
}
await expect(page).toHaveScreenshot();
});
}

Expand Down Expand Up @@ -533,15 +538,15 @@ test.describe(`${TAG.VISUAL} `, () => {
});
}

if (!item.active && !item.disabled) {
if (!item.active && !item.disabled && !item.loading) {
await test.step(`Verify focus styles for not active button styles`, async () => {
await page.keyboard.press('Tab');
await locators.button(page).nth(0).hover();
await expect(page).toHaveScreenshot();
});
}

if (item.active && !item.disabled) {
if (item.active && !item.disabled && !item.loading) {
await test.step(`Verify focus styles for active button styles`, async () => {
await page.keyboard.press('Tab');
await expect(page).toHaveScreenshot();
Expand All @@ -553,6 +558,7 @@ test.describe(`${TAG.VISUAL} `, () => {
for (let i = 0; i < count; i++) {
await expect(locators.button(page).nth(i)).toHaveAttribute('aria-busy', 'true');
}
await expect(page).toHaveScreenshot();
});
}

Expand All @@ -573,7 +579,7 @@ test.describe(`${TAG.VISUAL} `, () => {
await locators.button(page).first().waitFor({ state: 'visible' });
await page.waitForTimeout(100);

if (!item.active && !item.disabled) {
if (!item.active && !item.disabled && !item.loading) {
await test.step(`Verify focus styles for not active button styles`, async () => {
await page.keyboard.press('Tab');
await expect(locators.button(page).first()).toBeFocused();
Expand All @@ -588,7 +594,7 @@ test.describe(`${TAG.VISUAL} `, () => {
});
}

if (item.active && !item.disabled) {
if (item.active && !item.disabled && !item.loading) {
await test.step(`Verify focus styles for active button styles`, async () => {
await locators.button(page).nth(1).hover();
await page.getByText('Hint Button Addon').waitFor({ state: 'visible' });
Expand All @@ -602,8 +608,8 @@ test.describe(`${TAG.VISUAL} `, () => {
});
}

if (item.disabled) {
await test.step(`Verify disabled styles`, async () => {
if (item.disabled || item.loading) {
await test.step(`Verify disabled / loading styles`, async () => {
await expect(page).toHaveScreenshot();
});
}
Expand Down
Binary file modified ...l-them-50434-e-active-false-loading-true-hintPlacement-top-1-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...-l-them-50434-e-active-false-loading-true-hintPlacement-top-1-firefox-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...e-l-them-50434-e-active-false-loading-true-hintPlacement-top-1-webkit-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...l-them-56d1c--active-false-loading-true-hintPlacement-left-1-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...-l-them-56d1c--active-false-loading-true-hintPlacement-left-1-firefox-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...e-l-them-56d1c--active-false-loading-true-hintPlacement-left-1-webkit-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...l-them-7956e-e-active-false-loading-true-hintPlacement-top-1-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...-l-them-7956e-e-active-false-loading-true-hintPlacement-top-1-firefox-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...e-l-them-7956e-e-active-false-loading-true-hintPlacement-top-1-webkit-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...l-them-8a4c2-e-active-false-loading-true-hintPlacement-top-1-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...-l-them-8a4c2-e-active-false-loading-true-hintPlacement-top-1-firefox-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...e-l-them-8a4c2-e-active-false-loading-true-hintPlacement-top-1-webkit-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...l-them-b9302-ctive-false-loading-true-hintPlacement-bottom-1-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...-l-them-b9302-ctive-false-loading-true-hintPlacement-bottom-1-firefox-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...e-l-them-b9302-ctive-false-loading-true-hintPlacement-bottom-1-webkit-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...m-them-0423d-e-active-false-loading-true-hintPlacement-top-1-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...-m-them-0423d-e-active-false-loading-true-hintPlacement-top-1-firefox-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...e-m-them-0423d-e-active-false-loading-true-hintPlacement-top-1-webkit-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...m-them-45f0b-e-active-false-loading-true-hintPlacement-top-1-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...-m-them-45f0b-e-active-false-loading-true-hintPlacement-top-1-firefox-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...e-m-them-45f0b-e-active-false-loading-true-hintPlacement-top-1-webkit-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...m-them-51d54-active-false-loading-true-hintPlacement-right-1-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...-m-them-51d54-active-false-loading-true-hintPlacement-right-1-firefox-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...e-m-them-51d54-active-false-loading-true-hintPlacement-right-1-webkit-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...m-them-7bbee--active-false-loading-true-hintPlacement-left-1-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...-m-them-7bbee--active-false-loading-true-hintPlacement-left-1-firefox-linux.png
View file
Open in desktop
Binary file modified ...e-m-them-7bbee--active-false-loading-true-hintPlacement-left-1-webkit-linux.png
View file
Open in desktop
Binary file modified ...m-them-8e208-e-active-false-loading-true-hintPlacement-top-1-chromium-linux.png
View file
Open in desktop
Binary file modified ...-m-them-8e208-e-active-false-loading-true-hintPlacement-top-1-firefox-linux.png
View file
Open in desktop
Binary file modified ...e-m-them-8e208-e-active-false-loading-true-hintPlacement-top-1-webkit-linux.png
View file
Open in desktop
Binary file modified ...eme-primary-brand-disabled-false-active-false-loading-true-1-chromium-linux.png
View file
Open in desktop
Binary file modified ...heme-primary-brand-disabled-false-active-false-loading-true-1-firefox-linux.png
View file
Open in desktop
Binary file modified ...theme-primary-brand-disabled-false-active-false-loading-true-1-webkit-linux.png
View file
Open in desktop
Binary file modified ...heme-primary-info-disabled-false-active-false-loading-true-1-chromium-linux.png
View file
Open in desktop
Binary file modified ...theme-primary-info-disabled-false-active-false-loading-true-1-firefox-linux.png
View file
Open in desktop
Binary file modified ...-theme-primary-info-disabled-false-active-false-loading-true-1-webkit-linux.png
View file
Open in desktop
Binary file modified ...e-primary-success-disabled-false-active-false-loading-true-1-chromium-linux.png
View file
Open in desktop
Binary file modified ...me-primary-success-disabled-false-active-false-loading-true-1-firefox-linux.png
View file
Open in desktop
Binary file modified ...eme-primary-success-disabled-false-active-false-loading-true-1-webkit-linux.png
View file
Open in desktop
Binary file modified ...e-secondary-muted-disabled-false-active-false-loading-true-1-chromium-linux.png
View file
Open in desktop
Binary file modified ...me-secondary-muted-disabled-false-active-false-loading-true-1-firefox-linux.png
View file
Open in desktop
Binary file modified ...eme-secondary-muted-disabled-false-active-false-loading-true-1-webkit-linux.png
View file
Open in desktop
Binary file modified ...me-tertiary-muted-disabled-false-active-false-loading-true-1-chromium-linux.png
View file
Open in desktop
Binary file modified ...eme-tertiary-muted-disabled-false-active-false-loading-true-1-firefox-linux.png
View file
Open in desktop
Binary file modified ...heme-tertiary-muted-disabled-false-active-false-loading-true-1-webkit-linux.png
View file
Open in desktop
Binary file modified ...eme-primary-brand-disabled-false-active-false-loading-true-1-chromium-linux.png
View file
Open in desktop
Binary file modified ...heme-primary-brand-disabled-false-active-false-loading-true-1-firefox-linux.png
View file
Open in desktop
Binary file modified ...theme-primary-brand-disabled-false-active-false-loading-true-1-webkit-linux.png
View file
Open in desktop
Binary file modified ...me-primary-danger-disabled-false-active-false-loading-true-1-chromium-linux.png
View file
Open in desktop
Binary file modified ...eme-primary-danger-disabled-false-active-false-loading-true-1-firefox-linux.png
View file
Open in desktop
Binary file modified ...heme-primary-danger-disabled-false-active-false-loading-true-1-webkit-linux.png
View file
Open in desktop
Binary file modified ...me-primary-invert-disabled-false-active-false-loading-true-1-chromium-linux.png
View file
Open in desktop
Binary file modified ...eme-primary-invert-disabled-false-active-false-loading-true-1-firefox-linux.png
View file
Open in desktop
Binary file modified ...heme-primary-invert-disabled-false-active-false-loading-true-1-webkit-linux.png
View file
Open in desktop
Binary file modified ...e-seco-3f966-vert-disabled-false-active-false-loading-true-1-chromium-linux.png
View file
Open in desktop
Binary file modified ...me-seco-3f966-vert-disabled-false-active-false-loading-true-1-firefox-linux.png
View file
Open in desktop
Binary file modified ...eme-seco-3f966-vert-disabled-false-active-false-loading-true-1-webkit-linux.png
View file
Open in desktop
Binary file modified ...e-tertiary-invert-disabled-false-active-false-loading-true-1-chromium-linux.png
View file
Open in desktop
Binary file modified ...me-tertiary-invert-disabled-false-active-false-loading-true-1-firefox-linux.png
View file
Open in desktop
Binary file modified ...eme-tertiary-invert-disabled-false-active-false-loading-true-1-webkit-linux.png
View file
Open in desktop
Binary file modified ...e-size-05dc6-cess-disabled-false-active-false-loading-true-1-chromium-linux.png
View file
Open in desktop
Binary file modified ...le-size-05dc6-cess-disabled-false-active-false-loading-true-1-firefox-linux.png
View file
Open in desktop
Binary file modified ...ple-size-05dc6-cess-disabled-false-active-false-loading-true-1-webkit-linux.png
View file
Open in desktop
Binary file modified ...e-size-07dad-vert-disabled-false-active-false-loading-true-1-chromium-linux.png
View file
Open in desktop
Binary file modified ...le-size-07dad-vert-disabled-false-active-false-loading-true-1-firefox-linux.png
View file
Open in desktop
Binary file modified ...ple-size-07dad-vert-disabled-false-active-false-loading-true-1-webkit-linux.png
View file
Open in desktop
Binary file modified ...e-size-0dca3-info-disabled-false-active-false-loading-true-1-chromium-linux.png
View file
Open in desktop
Binary file modified ...le-size-0dca3-info-disabled-false-active-false-loading-true-1-firefox-linux.png
View file
Open in desktop
Binary file modified ...ple-size-0dca3-info-disabled-false-active-false-loading-true-1-webkit-linux.png
View file
Open in desktop
Binary file modified ...e-size-277fc-vert-disabled-false-active-false-loading-true-1-chromium-linux.png
View file
Open in desktop
Binary file modified ...le-size-277fc-vert-disabled-false-active-false-loading-true-1-firefox-linux.png
View file
Open in desktop
Binary file modified ...ple-size-277fc-vert-disabled-false-active-false-loading-true-1-webkit-linux.png
View file
Open in desktop
Binary file modified ...le-size-432ce-ess-disabled-false-active-false-loading-false-1-firefox-linux.png
View file
Open in desktop
Binary file modified ...ple-size-432ce-ess-disabled-false-active-false-loading-false-1-webkit-linux.png
View file
Open in desktop
Binary file modified ...e-size-508f4-rand-disabled-false-active-false-loading-true-1-chromium-linux.png
View file
Open in desktop
Binary file modified ...le-size-508f4-rand-disabled-false-active-false-loading-true-1-firefox-linux.png
View file
Open in desktop
Binary file modified ...ple-size-508f4-rand-disabled-false-active-false-loading-true-1-webkit-linux.png
View file
Open in desktop
Binary file modified ...e-size-5e4e1-rand-disabled-false-active-false-loading-true-1-chromium-linux.png
View file
Open in desktop
Binary file modified ...le-size-5e4e1-rand-disabled-false-active-false-loading-true-1-firefox-linux.png
View file
Open in desktop
Binary file modified ...ple-size-5e4e1-rand-disabled-false-active-false-loading-true-1-webkit-linux.png
View file
Open in desktop
Binary file modified ...e-size-78a24-vert-disabled-false-active-false-loading-true-1-chromium-linux.png
View file
Open in desktop
Binary file modified ...le-size-78a24-vert-disabled-false-active-false-loading-true-1-firefox-linux.png
View file
Open in desktop
Binary file modified ...ple-size-78a24-vert-disabled-false-active-false-loading-true-1-webkit-linux.png
View file
Open in desktop
Binary file modified ...e-size-d042a-nger-disabled-false-active-false-loading-true-1-chromium-linux.png
View file
Open in desktop
Binary file modified ...le-size-d042a-nger-disabled-false-active-false-loading-true-1-firefox-linux.png
View file
Open in desktop
Binary file modified ...ple-size-d042a-nger-disabled-false-active-false-loading-true-1-webkit-linux.png
View file
Open in desktop
Binary file modified ...e-size-e6256-uted-disabled-false-active-false-loading-true-1-chromium-linux.png
View file
Open in desktop
Binary file modified ...le-size-e6256-uted-disabled-false-active-false-loading-true-1-firefox-linux.png
View file
Open in desktop
Binary file modified ...ple-size-e6256-uted-disabled-false-active-false-loading-true-1-webkit-linux.png
View file
Open in desktop
Binary file modified ...e-size-fd4b3-uted-disabled-false-active-false-loading-true-1-chromium-linux.png
View file
Open in desktop
Binary file modified ...le-size-fd4b3-uted-disabled-false-active-false-loading-true-1-firefox-linux.png
View file
Open in desktop
Binary file modified ...ple-size-fd4b3-uted-disabled-false-active-false-loading-true-1-webkit-linux.png
View file
Open in desktop
2 changes: 1 addition & 1 deletion semcore/button/src/component/Button/Button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ export class RootButton extends Component<
type='button'
tag='button'
tabIndex={0}
disabled={disabled}
use:disabled={disabled || loading}
use:theme={useTheme}
ref={this.containerRef}
aria-busy={loading}
Expand Down
2 changes: 1 addition & 1 deletion semcore/feature-highlight/__tests__/feature-highlight.browser-test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ test.describe(`${TAG.VISUAL} `, () => {
const button = locators.buttons(page);
await expect(page).toHaveScreenshot();

if (!item.disabled) {
if (!item.disabled && !item.loading) {
await test.step('Verify focus style for buttons', async () => {
await page.keyboard.press('Tab');

Expand Down
Binary file modified ...rimary--544fa-l-active-false-loading-false-useBadge-accent-1-chromium-linux.png
View file
Open in desktop
Binary file modified ...primary--544fa-l-active-false-loading-false-useBadge-accent-1-firefox-linux.png
View file
Open in desktop
Binary file modified ...-primary--544fa-l-active-false-loading-false-useBadge-accent-1-webkit-linux.png
View file
Open in desktop
Binary file modified ...rimary--75920-active-false-loading-true-useBadge-undefined-1-chromium-linux.png
View file
Open in desktop
Binary file modified ...primary--75920-active-false-loading-true-useBadge-undefined-1-firefox-linux.png
View file
Open in desktop
Binary file modified ...-primary--75920-active-false-loading-true-useBadge-undefined-1-webkit-linux.png
View file
Open in desktop
Binary file removed ...rimary--c6155-active-false-loading-true-useBadge-undefined-2-chromium-linux.png
View file
Open in desktop
Diff not rendered.
Binary file removed ...primary--c6155-active-false-loading-true-useBadge-undefined-2-firefox-linux.png
View file
Open in desktop
Diff not rendered.
Binary file removed ...-primary--c6155-active-false-loading-true-useBadge-undefined-2-webkit-linux.png
View file
Open in desktop
Diff not rendered.
Binary file modified ...rimary--fe0a4--active-false-loading-false-useBadge-neutral-1-chromium-linux.png
View file
Open in desktop
Binary file modified ...primary--fe0a4--active-false-loading-false-useBadge-neutral-1-firefox-linux.png
View file
Open in desktop
Binary file modified ...-primary--fe0a4--active-false-loading-false-useBadge-neutral-1-webkit-linux.png
View file
Open in desktop
Binary file modified ...econdar-bf746-active-false-loading-true-useBadge-undefined-1-chromium-linux.png
View file
Open in desktop
Binary file modified ...secondar-bf746-active-false-loading-true-useBadge-undefined-1-firefox-linux.png
View file
Open in desktop
Binary file modified ...-secondar-bf746-active-false-loading-true-useBadge-undefined-1-webkit-linux.png
View file
Open in desktop
Binary file removed ...econdar-c8cbe-active-false-loading-true-useBadge-undefined-2-chromium-linux.png
View file
Open in desktop
Diff not rendered.
Binary file removed ...secondar-c8cbe-active-false-loading-true-useBadge-undefined-2-firefox-linux.png
View file
Open in desktop
Diff not rendered.
Binary file removed ...-secondar-c8cbe-active-false-loading-true-useBadge-undefined-2-webkit-linux.png
View file
Open in desktop
Diff not rendered.
1 change: 0 additions & 1 deletion tools/builder/src/unplugin-semcore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ export const unpluginSemcoreResolve = createUnplugin<{ rootPath: string }>((opts
return id.includes('/semcore/');
},
async load(id) {
console.log('load', id);
const { code } = await loadSemcoreSources(id);

return {
Expand Down
Loading