Repository navigation
fix(deps): update module github.com/mdp/qrterminal/v3 to v4 - #4284
renovate[bot] wants to merge 1 commit into
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
There was a problem hiding this comment.
Stale comment
Security review
Outcome: No medium, high, or critical vulnerabilities identified in this PR.
Scope reviewed: Added lines in
go.mod/go.sumonly (github.com/mdp/qrterminal/v4 v4.0.0). No application or CLI code changes.Analysis:
- The binary still imports and calls
github.com/mdp/qrterminal/v3(cli/cmd/user_totp.go); the new/v4module is not referenced, so this change does not alter runtime behavior or attacker-reachable sinks.- TOTP QR rendering continues to pass server-generated
otpauth://URLs toqrterminal.GenerateWithConfigon stdout (existing CLI/admin path); nothing in the diff changes that data flow.go mod verifysucceeds for the added module path; no evidence of a dependency substitution or new externally controlled parsing surface from this diff alone.Note: This looks like an incomplete Renovate bump (v4 declared but v3 not removed/migrated). That is a maintenance/build hygiene issue, not a demonstrated security defect in the changed lines.
No prior automation review threads were present on this PR.
Sent by Cursor Automation: Find vulnerabilities
d993be1 to
6494e8c
Compare
There was a problem hiding this comment.
Security review
Outcome: No medium, high, or critical vulnerabilities identified in this PR.
Scope reviewed: Added lines in go.mod / go.sum only (github.com/mdp/qrterminal/v4 v4.0.0). Application code still imports github.com/mdp/qrterminal/v3; the new module is not referenced, so runtime behavior and the dependency graph for the built binary are unchanged.
Prior findings: No open automation review threads on this PR. The previous assessment (no exploitable issues in the dependency-only diff) still applies after re-checking TOTP/QR usage in cli/cmd/user_totp.go and the v4 module metadata.
Supply chain note (informational, below reporting threshold): v4 is the same upstream project (MIT) as v3. A full migration would warrant reviewing new terminal/sixel code paths; this PR does not enable them.
Sent by Cursor Automation: Find vulnerabilities
6494e8c to
ab6b8d2
Compare
ab6b8d2 to
ca9c3e7
Compare


This PR contains the following updates:
v3.2.1→v4.0.0Release Notes
mdp/qrterminal (github.com/mdp/qrterminal/v3)
v4.0.0Compare Source
Changelog
54842d8Fix Sixel terminal-state handling with newer golang.org/x/termc421bbaFix phantom row/column in block rendering6c0d149Make sixel opt-in; fix half-block border bands and QuietZone 070ca581Merge pull request #41 from mdp/ci-tests531e661Merge pull request #43 from mdp/fix/sixel-optin-halfblock-border-quietzone684b5feRemove oryxBuildBinary7064f5dchore: lower go directive to 1.25.08b0c669ci: run build and tests on PRs and main6ab42b5cli: accept flags after operands9f8b1b9fix: fix panic with newer term version for Sixel support and fix restore, update dependenciesa7e6725release: v4.0.0 changelog and major module bump to /v46579f03remove oryxBuildBinaryReleased by GoReleaser.
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.