fix(ci): align ECR mock_balances build-arg name with Dockerfile#3302
Merged
fix(ci): align ECR mock_balances build-arg name with Dockerfile#3302
Conversation
The ECR workflow passed `SEI_CHAIN_BUILD_TAGS=mock_balances`, but the Dockerfile declares `ARG GO_BUILD_TAGS=""`. Docker silently ignores the mismatched arg, so the resulting `sei/sei-chain:mock-<sha>` image was built without the `mock_balances` tag — it was a regular build, just labeled differently. Rename the workflow arg to `GO_BUILD_TAGS` so the build tag actually reaches `go build`. Discovered during the v6-5 soak when our expected `mock_balances` behavior was absent on pods pulling the ECR mock image; verified by inspecting `seid version` BuildTags on the produced image. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
blindchaser
approved these changes
Apr 22, 2026
amir-deris
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The ECR workflow passed
SEI_CHAIN_BUILD_TAGS=mock_balancesas a Docker build-arg, but the Dockerfile declaresARG GO_BUILD_TAGS="". Docker silently ignores build-args that don't match a declared ARG, so the resultingsei/sei-chain:mock-<sha>image was being built without themock_balancestag — a regular build just labeled as mock.Change
One-line rename in
.github/workflows/ecr.yml:No Dockerfile change;
GO_BUILD_TAGSis the name the builder has always read. Confirmed viagit log -S SEI_CHAIN_BUILD_TAGS: this workflow was introduced (Jan 8 2026) already broken — the Dockerfile has usedGO_BUILD_TAGSsince Dec 12 2025; the names never aligned in any commit.How this was discovered
During the
v6-5-run-3soak on our k8s cluster, nodes pulling the ECRmock-<sha>image didn't exhibit the expected mock-balances behavior. I worked around it at the time by building a mock image locally and pushing it to my personal registry; this PR is the proper fix so the CI-produced image is actually a mock build.Behavior change after merge (heads-up for downstream consumers)
Several platform-side consumers pull
sei/sei-chain:mock-<sha>by tag name:autobake/README.md/.github/workflows/k8s_autobake.ymlgprusak/README.mdclusters/dev/release-6-4/kustomization.yamlclusters/dev/release-6-3/kustomization.yamlAfter this merge, new
mock-<sha>tags will actually carrymock_balancesbehavior for the first time since the workflow was introduced. Existing images already pulled into clusters are unchanged; this only affects future ECR builds. Therelease-6-3/release-6-4dev clusters and autobake runs will start exhibiting real mock semantics on their next image roll — that's the intended behavior, calling it out so no one is surprised.Companion PR: sei-protocol/platform#141 fixes the same bug in
ecr-seid-musl.yml.Test plan
GO_BUILD_TAGSis the only build-tags ARG; no other workflow or script referencesSEI_CHAIN_BUILD_TAGS.seid versionon the next CI-producedmock-<sha>image reportsnetgo ledger mock_balancesin BuildTags (not justnetgo ledger).🤖 Generated with Claude Code