Open
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3293 +/- ##
=======================================
Coverage 59.36% 59.36%
=======================================
Files 2072 2072
Lines 169953 169949 -4
=======================================
- Hits 100895 100894 -1
+ Misses 60275 60271 -4
- Partials 8783 8784 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
wen-coding
approved these changes
Apr 21, 2026
| exit 1 | ||
| fi | ||
|
|
||
| OLD_TAG=$(grep -v '^[[:space:]]*$' "$TAG_FILE" | tail -n 1) |
Contributor
There was a problem hiding this comment.
nit: I like how you are skipping whitespace only lines, it would be nice if we can make this a shell function.
bdchatham
approved these changes
Apr 21, 2026
Contributor
bdchatham
left a comment
bdchatham
left a comment
There was a problem hiding this comment.
Looks good and differences are expected based on the recent semver change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Add v6.5 upgrade handler. Note that we're moving from v${Major}.${Minor}.${Patch} to just v${Major}.${Minor} i.e. v6.4.0 -> v6.5, changes included in
scripts/bump-version.shTesting performed to validate your change
Ran script, verified output