[fallenbagel]

Description

The Quick Connect button was shown on the login screen for any Jellyfin-family server, but Emby doesn't support Quick Connect, so clicking it there always failed with an error. This hides the button when the configured server is Emby, showing it only for Jellyfin.

• Fixes Quick connect should be hidden when using Emby #3364

How Has This Been Tested?

• Ran the unit test and UI just self-explanatory that it would work anyways

Screenshots / Logs (if applicable)

Checklist:

• I have read and followed the contribution guidelines.
• Disclosed any use of AI (see our policy)
• I have updated the documentation accordingly.
• All new and existing tests passed.
• Successful build pnpm build
• Translation keys pnpm i18n:extract
• Database migration (if required)

Summary by CodeRabbit

• Bug Fixes

  • Quick Connect is now available only for Jellyfin servers.
  • Non-Jellyfin configurations receive a clear access error instead of attempting an unsupported connection.
  • Added safeguards to prevent invalid Quick Connect requests and account-linking attempts.

• UI Improvements

  • The Quick Connect button is hidden when the selected media server is not Jellyfin.
  • Jellyfin account linking now consistently uses the correct account type.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a5e09841-e93b-4104-aea4-190fc68d0e4c

📥 Commits

Reviewing files that changed from the base of the PR and between b7e10d9 and 29128a7.

📒 Files selected for processing (5)

• server/routes/auth.test.ts
• server/routes/auth.ts
• server/routes/user/usersettings.test.ts
• server/routes/user/usersettings.ts
• src/components/UserProfile/UserSettings/UserLinkedAccountsSettings/LinkJellyfinModal.tsx

🚧 Files skipped from review as they are similar to previous changes (1)

• server/routes/auth.ts

---

📝 Walkthrough

Walkthrough

Quick Connect now supports Jellyfin configurations only. Server routes and account linking return HTTP 403 for Emby. The login and linked-account interfaces hide Quick Connect controls for Emby. Tests verify rejection, skipped Jellyfin calls, and successful Jellyfin linking.

Changes

Quick Connect gating

Layer / File(s)	Summary
Server-side Quick Connect validation server/routes/auth.ts, server/routes/auth.test.ts	The initiation, status-check, and authentication routes reject non-Jellyfin configurations with HTTP 403. New authenticated users use UserType.JELLYFIN. Tests verify rejected Emby requests and skipped Jellyfin API calls.
Quick Connect account linking server/routes/user/usersettings.ts, server/routes/user/usersettings.test.ts	Account linking rejects Emby with HTTP 403. Successful links persist the Jellyfin user ID and UserType.JELLYFIN.
Conditional Quick Connect controls src/components/Login/JellyfinLogin.tsx, src/components/UserProfile/UserSettings/UserLinkedAccountsSettings/LinkJellyfinModal.tsx	Both components render Quick Connect controls only for Jellyfin configurations.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Possibly related PRs

• seerr-team/seerr#2212: Introduced the Quick Connect routes, interface components, and account-linking behavior updated here.

Suggested reviewers: 0xsysr3ll, gauthier-th

Poem

A rabbit guards the Jellyfin gate,
Emby requests must now wait.
The buttons hide, the calls stay still,
Linked users bear the proper type.
Quick Connect hops with careful skill.

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the primary change: hiding the Quick Connect button for Emby servers.
Linked Issues check	✅ Passed	[#3364] The PR hides Quick Connect for Emby, uses serverType, and prevents unsupported Emby Quick Connect requests.
Out of Scope Changes check	✅ Passed	The backend guards and tests directly support preventing unsupported Emby Quick Connect flows, so the changes remain in scope.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

This PR prevents users from attempting Jellyfin Quick Connect against Emby servers (which don’t support it), eliminating a guaranteed error path on the login screen and adding a server-side safeguard.

Changes:

• Hide the Quick Connect button in the Jellyfin login UI unless the configured server type is Jellyfin.
• Add a server-side 403 guard on Quick Connect initiation when the media server type is not Jellyfin.
• Add a unit test verifying the 403 behavior when configured for Emby.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/components/Login/JellyfinLogin.tsx	Conditionally renders the Quick Connect button only for Jellyfin servers.
server/routes/auth.ts	Rejects Quick Connect initiation requests unless Jellyfin is the configured server type.
server/routes/auth.test.ts	Adds test coverage for the new 403 behavior when media server type is Emby.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.