[fallenbagel]

Description

Previously, stopping the Jellyfin server and hitting Sync Libraries returned "Something went wrong while syncing libraries" with no real error in Setup, because the connection failure got treated the same as "no libraries found," and the fallback check for that case failed too and threw the wrong error entirely. Now sync distinguishes an unreachable server from an empty library list, and the toast says the server is unreachable instead of giving a generic error.

Connection failures in every Jellyfin API method threw either InvalidAuthToken or a bare Unknown error on any failure, so a downed server looked like a bad token everywhere. Login now catches this too: signing in while Jellyfin is unreachable gives the same "unable to connect" message instead of a generic login failure. Plex sync no longer silently
clears the library list on failure either and it throws, so both the route and the startup migration can leave existing config in place and let the user (or the next boot) retry.

In addition, Setup's Continue gate used to run its own validation request that toasted on failure. Switching that to reuse the settings data already being fetched removes a redundant request on every library toggle, but that path is silent on failure, so this PR adds an inline alert to keep users from being stuck on a disabled Continue button with no explanation.

Moreover, scan status polling ran at a constant 1 second regardless of whether a sync was actually in progress. It now backs off to 10 seconds when idle and only ramps up while scanning. This should cut idle traffic significantly without missing scans triggered by the job scheduler.

Also cleans up now-unused setup-flow state and makes Plex's setup-mode handling consistent with Jellyfin's.

How Has This Been Tested?

• On a fresh setup tested the /Setup library sync and toggling.

Screenshots / Logs (if applicable)

Checklist:

• I have read and followed the contribution guidelines.
• Disclosed any use of AI (see our policy)
• I have updated the documentation accordingly.
• All new and existing tests passed.
• Successful build pnpm build
• Translation keys pnpm i18n:extract
• Database migration (if required)

Summary by CodeRabbit

• Bug Fixes

  • Improved Plex and Jellyfin connection error handling with clearer, dedicated messages.
  • Prevented library settings from being cleared when synchronization fails.
  • Plex library migration failures no longer prevent startup and will retry later.

• Improvements

  • Library synchronization now checks more frequently while active and less frequently when idle.
  • Setup library completion is determined automatically from loaded libraries.
  • Setup displays an inline error when libraries cannot be loaded.
  • Updated Jellyfin login and setup messages for unreachable servers.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ae2e0c33-7ab6-4f43-9fe9-2c3ad92ef862

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: better handling of connection failures in media server sync and login flows.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

This PR refactors the setup/media-server settings screens to reduce redundant SWR traffic and ensure the Setup “Continue” gate reflects the current SWR cache (instead of manual validation callbacks/state).

Changes:

• Stop constant 1s polling of /settings/{plex,jellyfin}/sync by making refreshInterval conditional on running.
• Remove the Setup-time double-fetch by subscribing Setup to the same SWR settings key as the settings components (dropping validateLibraries / onComplete callback wiring).
• Introduce a dedicated isSetupSettings prop for SettingsPlex (matching the existing Jellyfin pattern), avoiding use of a callback prop as a mode flag.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
src/i18n/locale/en.json	Removes an unused Setup validation error string.
src/components/Setup/index.tsx	Switches Setup “Continue” gating to derive from SWR-cached media server settings (removes callback-driven validation).
src/components/Settings/SettingsPlex.tsx	Adds isSetupSettings prop and changes sync polling to be conditional on running.
src/components/Settings/SettingsJellyfin.tsx	Removes onComplete callback usage and changes sync polling to be conditional on running.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

server/api/jellyfin.ts:418

• In the getLibraries fallback, any HTTP error from the /Views request (e.response present, e.g. 500) currently returns an empty array. Callers then interpret this as “no libraries” and may surface SYNC_ERROR_NO_LIBRARIES, masking real server/API failures. Consider throwing an ApiError for response errors so upstream can distinguish “request failed” from “no libraries found.”

        if (!e.response) {
          throw new ApiError(502, ApiErrorCode.ConnectionError);
        }

        return [];

src/components/Setup/index.tsx:85

• mediaServerSettingsComplete is derived only from the last known libraries data. If SWR has cached data but the current revalidation errored (mediaServerSettingsError), the Setup “Continue” gate can still be treated as complete even though libraries failed to load. Folding the error state into the completeness calculation keeps the gate consistent with the inline error alert.

  const mediaServerSettingsComplete = !!mediaServerSettings?.libraries?.some(
    (library) => library.enabled
  );

[0xSysR3ll]

LGTM!