Repository navigation
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThree new webhook template variables— ChangesWebhook User ID Template Variables
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hello, We won’t merge this PR because improvements in seerr-team/seerr#2039 will already allow you to achieve the same functionality with custom webhook template and full access to seerr object. |
Description
requestedBy_id,reportedBy_id,commentedBy_idthat map to the user ID in theWebhookAgent'sKeyMapAllows to identify users without using
displayNameoremail, which can be changed at any time, and can be similar to another user. This is also made for non-Jellyfin user accounts.No AI tools have been used for this PR
How Has This Been Tested?
This has not been tested, only successfully built using
pnpm build(as mentionned in Checklist)Screenshots / Logs (if applicable)
Note
Screenshots are not related to Seerr itself, but to a webhook server running SeerrAPN
On this first attachment, we can see the current way to check which user requested a media, from a list of
seerrUsernames. This can conflict if two users have the same display name, which is not the intended behavior.On this second screenshot, we also check which user requested a media, from a list of
seerrIds. Seerr user IDs is required so targetted notifications are sent to the right user, since there cannot be two users with the same ID.Checklist:
pnpm buildpnpm i18n:extractSummary by CodeRabbit
requestedBy_id,reportedBy_id, andcommentedBy_idplaceholders.