Repository navigation
Drop fetch_lobs compatibility probe; require seerdb>=3.0.0 and Python 3.11 - #26
Merged
Merged
Conversation
… 3.11 seerdb 3.0.0 is released and is now the driver floor, so the import-time probe for fetch_lobs support is dead weight -- the branch can never be False. - pyproject: seerdb>=2.5.0 -> seerdb>=3.0.0 - remove _driver_has_fetch_lobs() / _DRIVER_HAS_FETCH_LOBS - pass fetch_lobs=False unconditionally in create_connect_args - CI: move the SQLAlchemy pin 2.0.54 -> 2.1.0 in tests.yml and compliance.yml (seerdb 2.5.0 failed BooleanTest on 23ai under SQLAlchemy 2.1, fixed in 3.0.0) - entry-point smoke test now asserts fetch_lobs unconditionally - Python floor 3.10 -> 3.11: SQLAlchemy 2.1 requires 3.11, so the pinned version cannot install on 3.10, and 3.10 reaches end of life in October 2026. The Package matrix drops 3.10 and the lint job runs on 3.11. The driver keeps its own floor; this is the dialect's alone. Dropping pre-3.0 driver support and Python 3.10 is a minor bump: 0.2.2 -> 0.3.0. Closes #16 Signed-off-by: Peter Lemenkov <lemenkov@gmail.com> Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
lemenkov
force-pushed
the
drop-fetch-lobs-probe-floor-3.0
branch
from
October 13, 2026 16:32
ac02846 to
6c248d8
Compare
lemenkov
changed the title
This was referenced Oct 13, 2026
Merged
lemenkov
added a commit
that referenced
this pull request
Oct 13, 2026
#26 bumped pyproject.toml to 0.3.0 but left sqlalchemy_seerdb.__version__ at 0.2.2, so the release workflow's test_version failed on the 0.3.0 tag and nothing was published. The two places now agree again. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Executes the scheduled cleanup in #16, now that the driver floor has reached seerdb 3.0.0.
Changes
pyproject.toml:seerdb>=2.5.0→seerdb>=3.0.0; version0.2.2→0.3.0.seerdb.py: remove_driver_has_fetch_lobs()/_DRIVER_HAS_FETCH_LOBSand passfetch_lobs=Falseunconditionally increate_connect_args(the branch can never be False once the floor carries the option).2.0.54→2.1.0in bothtests.ymlandcompliance.yml. Per the discussion on Drop the fetch_lobs compatibility probe once the driver floor reaches 3.0 #16, seerdb 2.5.0 failsBooleanTeston 23ai under SQLAlchemy 2.1 (storesFalseasTRUE); that's fixed in seerdb 3.0.0, so with the floor raised the pin can move in the same change.fetch_lobsunconditionally (it's always present with a 3.0+ driver).>=3.10→>=3.11. SQLAlchemy 2.1 requires Python 3.11, so the pinned 2.1.0 can't install on 3.10; the first CI run of this PR failed on exactly that. Python 3.10 also reaches end of life in October 2026. The Package matrix drops 3.10, and the lint job runs on 3.11. The driver keeps its own floor (seerdb still supports 3.10); this change is the dialect's alone.Versioning
Raising the floor alone would be a patch, but dropping pre-3.0 driver support and Python 3.10 changes who can install the dialect, so this is a minor bump (0.2.2 → 0.3.0) per the repo's rule and the decision recorded in #16.
Validation
ruff check+ruff format --check: clean.create_connect_argsnow always includesfetch_lobs: Falseand matches the tightened assertion.Closes #16
🤖 Generated with Claude Code