Repository navigation
ci: tolerate feature-detected fetch_lobs in entry-point smoke test - #25
Merged
Merged
Conversation
The Package job's "Dialect resolves from its entry point" step asserted an exact create_connect_args dict. seerdb is unpinned (>=2.5.0) in pyproject, so CI now installs seerdb 3.0, whose presence makes the dialect add 'fetch_lobs': False via feature detection -- breaking the exact match and failing the job on every PR (and on master). Pop the optional 'fetch_lobs' key before the exact comparison and assert it separately, so the smoke test passes against both pre-3.0 and 3.0+ drivers, matching the dialect's intentional dual-driver support. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Packagejob's "Dialect resolves from its entry point" step asserts an exactcreate_connect_argsdict.seerdbis unpinned inpyproject.toml(seerdb>=2.5.0), so CI now installs seerdb 3.0, whose presence makes the dialect add'fetch_lobs': Falsevia feature detection (_DRIVER_HAS_FETCH_LOBS). That extra key breaks the exact match:The job therefore fails deterministically on every PR (and on
master— it merged previously only because this job isn't a required gate). Dependabot PRs are collateral: they trip the same broken job, which looks like the bump failing tests when it isn't.Fix
Pop the optional
fetch_lobskey before the exact comparison and assert it separately, so the smoke test passes against both pre-3.0 and 3.0+ drivers — matching the dialect's intentional dual-driver support (it works with or withoutfetch_lobs).No driver pin needed; no behavior change to the dialect.
Note
Once this lands on
master, the open dependabot PRs need a rebase (@dependabot rebase) to pick up the corrected workflow, after which they should go green.🤖 Generated with Claude Code