Skip to content

ci: tolerate feature-detected fetch_lobs in entry-point smoke test - #25

Merged
lemenkov merged 1 commit into
masterfrom
fix-fetch-lobs-smoke-test
Oct 13, 2026
Merged

lemenkov merged 1 commit into
masterfrom
fix-fetch-lobs-smoke-test

Conversation

@lemenkov

Copy link
Copy Markdown
Member

Problem

The Package job's "Dialect resolves from its entry point" step asserts an exact create_connect_args dict. seerdb is unpinned in pyproject.toml (seerdb>=2.5.0), so CI now installs seerdb 3.0, whose presence makes the dialect add 'fetch_lobs': False via feature detection (_DRIVER_HAS_FETCH_LOBS). That extra key breaks the exact match:

AssertionError: {'host': 'h', 'port': 1521, 'user': 'u', 'password': 'p',
                 'autocommit': False, 'fetch_lobs': False, 'service_name': 'XE', 'timeout': 5000}

The job therefore fails deterministically on every PR (and on master — it merged previously only because this job isn't a required gate). Dependabot PRs are collateral: they trip the same broken job, which looks like the bump failing tests when it isn't.

Fix

Pop the optional fetch_lobs key before the exact comparison and assert it separately, so the smoke test passes against both pre-3.0 and 3.0+ drivers — matching the dialect's intentional dual-driver support (it works with or without fetch_lobs).

No driver pin needed; no behavior change to the dialect.

Note

Once this lands on master, the open dependabot PRs need a rebase (@dependabot rebase) to pick up the corrected workflow, after which they should go green.

🤖 Generated with Claude Code

The Package job's "Dialect resolves from its entry point" step asserted an
exact create_connect_args dict. seerdb is unpinned (>=2.5.0) in pyproject, so
CI now installs seerdb 3.0, whose presence makes the dialect add
'fetch_lobs': False via feature detection -- breaking the exact match and
failing the job on every PR (and on master).

Pop the optional 'fetch_lobs' key before the exact comparison and assert it
separately, so the smoke test passes against both pre-3.0 and 3.0+ drivers,
matching the dialect's intentional dual-driver support.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
@lemenkov
lemenkov merged commit 9236b65 into master Oct 13, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant