Repository navigation
Release the geometry fixture program and check readback allocation - #958
Open
RobiiAragon wants to merge 1 commit into
Open
RobiiAragon wants to merge 1 commit into
RobiiAragon wants to merge 1 commit into
Conversation
This was referenced Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
I reproduced two LLVM 23.1.4 findings in
t_geometry_hazards.mon main1ae435d5: the readback buffer can be nil when passed to Metal, and the program retained by the serial registry remains registered after its scenario ends.I check the buffer allocation before the blit. Once the GPU has finished, I clear the draw bindings, remove the exact program entry under the registry lock, verify its identity and balance the registry’s CF retain. The production renderer, shader chain and lint baseline are unchanged. This also removes the main-branch lint failures I encountered while checking #956.
Checked
make -C dm/gfx/tests GAME=010015100B514000 check_t_geometry_hazards: 57 checks passed in each of its three configurations (early submission on, off, and geometry cuts off), with Metal validation enabled.Docs