Repository navigation
Test malformed HMMA helper signatures - #870
Open
thehobbit85 wants to merge 1 commit into
Open
thehobbit85 wants to merge 1 commit into
thehobbit85 wants to merge 1 commit into
Conversation
thehobbit85
force-pushed
the
codex/fix-heaps-fixture-types
branch
from
November 1, 2026 13:33
495c412 to
eb7211a
Compare
thehobbit85
changed the title
thehobbit85
force-pushed
the
codex/fix-heaps-fixture-types
branch
from
November 1, 2026 13:54
eb7211a to
162bc26
Compare
thehobbit85
changed the title
thehobbit85
force-pushed
the
codex/fix-heaps-fixture-types
branch
6 times, most recently
from
November 2, 2026 15:49
ede3d68 to
7f9e1e2
Compare
thehobbit85
force-pushed
the
codex/fix-heaps-fixture-types
branch
from
November 2, 2026 17:44
7f9e1e2 to
7dfd042
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add regression coverage for malformed HMMA helper signatures after upstream
0e8503e7incorporated the production guards and Heaps fixture assertion. Main fixes the original lint failures but lacks these malformed ordinary/scratch parameter-name and output-reference cases. Each must raiseValueErroridentifying the bad parameter; the tests detect removal of either guard.Revision
7dfd0420451bd1d90d8a441ecb093c45a3429408includes main65501fbbaf8526f7aab0a1edd028135888590f8e. The malformed HMMA signature fixtures are still absent from main.Validation on
7dfd0420451b.python3 -m unittest dm.tools.tests.test_docs dm.gfx.tests.test_dmsh_hmma— 17 tests passed.GitHub checks for this revision