Repository navigation
Pass the resolved LINKDATA index to shader scan workers - #1027
Open
thehobbit85 wants to merge 1 commit into
Open
thehobbit85 wants to merge 1 commit into
thehobbit85 wants to merge 1 commit into
Conversation
thehobbit85
force-pushed
the
codex/linkdata-index-job
branch
2 times, most recently
from
November 3, 2026 03:11
6eb52c1 to
feb7b6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LINKDATA companion lookup
Main now detects a missing LINKDATA index when a worker looks it up again. This PR keeps the actual path chosen at planning time and names that precise missing companion if it disappears. The independent regression covers both DATA0.bin and LI_*.IDX.
Current head
feb7b6c0cc3c391dad29189e3b69cac8e539d665.python3 -m unittest dm.tools.tests.test_docs dm.tools.tests.test_split_unreadable dm.tools.tests.test_split_nestingpassed on this revision (23 tests). The feature sources, tests and documentation match the previously validated revision6eb52c1df268byte for byte.This PR includes main
6136418bcd564f086cf57cb0a59e8f997d36445e. Main now detects a missing LINKDATA index when a worker looks it up again. This PR keeps the actual path chosen at planning time and names that precise missing companion if it disappears. The independent regression covers both DATA0.bin and LI_*.IDX.Local validation on
6eb52c1df268.python3 -m unittest dm.tools.tests.test_docs dm.tools.tests.test_split_unreadable dm.tools.tests.test_split_nesting— 23 tests passed.The exact baseline and PR both extracted the same ordered test payloads in both game formats. Removing the planned companion after dispatch made only the PR report the missing filename in both cases. Pinned Python lint reported zero new or stale findings.
scripts/regress.py check --no-smoke --games 010055D009F78000,0400A3A01EE4C000stopped at discovery (exit 2). Three Houses and Pokopia use the two known LINKDATA companion naming schemes. Only Z-A was installed. No game comparison ran.GitHub checks for this revision
Validation on the original proposal
DATA1.bin/DATA0.binand Pokémon Pokopia’sLD_C0_R.BIN/LI_C0_R.IDX. It checks missing indexes before planning, dispatch and payload order across two entry ranges, and index removal after planning. Both formats reproduced the missing-filename failure on the original code and passed with the change.03d92a9f. The generator fix cleared one. This change cleared the remaining two. The final result is 391 findings in the existing baseline, zero new and zero stale.