Repository navigation
feat(cli): choose the browser with SEDUM_BROWSER, per environment, or doctor --browser - #164
Merged
Merged
Conversation
… doctor --browser Resolve the browser from --browser, SEDUM_BROWSER (process, then .env), the selected environment's browser key, then the top-level key. sedum doctor accepts --browser, names the setting's source, and shows the first config diagnostic when the configuration does not load. Fall back to managed Chromium when Playwright reports a missing Chrome distribution, as it does on Linux without Google Chrome. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01U7KCKub793DH4xshQbHCGd
Architecture Data flow Tip Set 🪧 More tips
Thanks for using PR Lens! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out on X, Bluesky, Mastodon, Reddit or LinkedIn |
Preview approval requiredThis pull request comes from a fork, so Mintlify won't build a preview until someone with write access approves commit |
Keep loadProjectConfig, executeDoctorCommand and runCli from growing more complex: browser resolution, doctor's config overrides and its config failure check move into small functions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01U7KCKub793DH4xshQbHCGd
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01U7KCKub793DH4xshQbHCGd
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01U7KCKub793DH4xshQbHCGd
A flag or SEDUM_BROWSER no longer hides an unsupported `browser` key at the top level or in any environment, selected or not, the same way every `stepTimeoutMs` is checked. An unsupported SEDUM_BROWSER from the process environment or --browser value is reported at <process environment> or <command line> instead of line 1 of sedum.config.yaml. Co-authored-by: Bagrat <bagrat@timeline.co> Amp-Thread-ID: https://ampcode.com/threads/T-8894897a-ba72-47ec-b40f-2aacd96b4545 Co-authored-by: Ignacio Gutierrez <nachojgutierrez@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
--browser;SEDUM_BROWSER(the process environment, then the project.env);browserkey;browser;chrome.sedum doctoraccepts--browser. Its browser check says where the setting came from, e.g.chromium is available (from SEDUM_BROWSER).Chromium distribution 'chrome' is not found at …error.Why
We run the same suite on macOS, where Chrome is installed, and in Linux containers (Claude Code cloud sessions, CI), where it isn't.
--browseronrun, so a Linux machine needed a flag on every command.doctorcouldn't be told at all.browser: chromeon Linux,doctorsaid "chrome is available", becausefindBrowserExecutablefalls back to managed Chromium. Butlaunchdidn't recognise Playwright 1.63's missing-distribution message, so it never fell back, and every run failed.Verification
pnpm typecheckandpnpm lintare clean, andpnpm testpasses 1,450 tests (new: precedence,.envvs process, an invalid value per source,doctor --browser, the doctor config message, the Linux fallback).browser: chrome:doctorreports(from browser),(from SEDUM_BROWSER)and(from --browser)correctly;SEDUM_BROWSER=firefoxgives "Project configuration could not be loaded:SEDUM_BROWSERmust bechromeorchromium."doctorreports(from browser),(from SEDUM_BROWSER)and(from --browser), and thefirefoxerror;--browserused real Chrome;SEDUM_BROWSER=chromiumused managed Chromium;--browserflag (the fallback) and withSEDUM_BROWSER=chromium.